linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Asdo <asdo@shiftmail.org>
Cc: Alexander Lyakas <alex.bolshoy@gmail.com>,
	linux-raid <linux-raid@vger.kernel.org>
Subject: Re: On mdadm 3.2 and bad-block-log
Date: Wed, 18 Jul 2012 09:34:58 +1000	[thread overview]
Message-ID: <20120718093458.5e783b4a@notabene.brown> (raw)
In-Reply-To: <50052099.4000401@shiftmail.org>

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

On Tue, 17 Jul 2012 10:21:45 +0200 Asdo <asdo@shiftmail.org> wrote:

> On 07/17/12 03:49, NeilBrown wrote:
> > On Mon, 16 Jul 2012 10:56:27 +0200 Asdo<asdo@shiftmail.org>  wrote:
> >
> > Yes, there is a degree to which your data is at risk. This is always 
> > the case with new code. If you upgrade to new -stable kernels as they 
> > become available, that should minimise your risk as any fix that could 
> > risk data or stability is backported to these -stable kernels.
> 
> I am on kernel 3.4, that's "stable", right?

3.4.5 is the latest kernel in the 3.4.y stable series.
It contains:
 - a fix for bad-block handling in RAID5
 - a fix for a ref-counting bug in RAID5 that can trigger when updating
   the bad block list

So if you are using bad-block-logs on RAID5 you should definitely upgrade
to 3.4.5.  If some other level ... then it is probably a good idea to upgrade
anyway.

> 
> > I don't know of any particularly serious bugs that have been found - they
> > mostly are triggered by unusual conditions.  However unusual conditions do
> > happen.
> >
> > Thank you for using and testing the code.  Has md found and recorded any bad
> > blocks for you, or are your bad-block logs still empty?
> 
> Still empty for now
> They are filled only on read error + failed block rewrite, right? That 
> will take a long time to happen...

They can also be filled on a read-error during recovery of one device fails.
It is quite likely that none of this will happen for years.  But it might
happen tomorrow.

> 
> Thanks for your work
:-)

NeilBrown


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2012-07-17 23:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12 16:51 On mdadm 3.2 and bad-block-log Asdo
2012-07-11  9:40 ` Alexander Lyakas
2012-07-16  3:41   ` NeilBrown
2012-07-16  7:41     ` Asdo
2012-07-16  7:55       ` Alexander Lyakas
2012-07-16  8:56         ` Asdo
2012-07-16  9:08           ` Alexander Lyakas
2012-07-17  1:49           ` NeilBrown
2012-07-17  8:21             ` Asdo
2012-07-17 23:34               ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120718093458.5e783b4a@notabene.brown \
    --to=neilb@suse.de \
    --cc=alex.bolshoy@gmail.com \
    --cc=asdo@shiftmail.org \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).