From: majianpeng <majianpeng@gmail.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: Re: [RFC PATCH V1] raid5: Add R5_ReadNoMerge flag which prevent bio from merging at block layer
Date: Sat, 21 Jul 2012 12:35:52 +0800 [thread overview]
Message-ID: <201207211235474533141@gmail.com> (raw)
In-Reply-To: 20120716154822.2774ff5e@notabene.brown
On 2012-07-16 13:48 NeilBrown <neilb@suse.de> Wrote:
>On Fri, 13 Jul 2012 19:13:35 +0800 majianpeng <majianpeng@gmail.com> wrote:
>
>> Because bios will merge at block-layer,so bios-error may caused by other
>> bio which be merged into to the same request.
>> Using this flag,it will find exactly error-sector and not do redundant
>> operation like re-write and re-read.
>>
>> V0->V1:Using REQ_FLUSH instead REQ_NOMERGE avoid bio merging at block
>> layer.
>>
>> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
[snip]
>
>
>Thanks, I've applied this.
>
>We should probably do a similar thing in fix_read_error and
>fix_sync_read_error in RAID1 and RAID10...
>
I reviewed the code about fix_read_error/fix_sync_read_error.
It already do the similar thing.
>Thanks,
>NeilBrown
>
>
prev parent reply other threads:[~2012-07-21 4:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 11:13 [RFC PATCH V1] raid5: Add R5_ReadNoMerge flag which prevent bio from merging at block layer majianpeng
2012-07-16 5:48 ` NeilBrown
2012-07-16 6:57 ` majianpeng
2012-07-21 4:35 ` majianpeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207211235474533141@gmail.com \
--to=majianpeng@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).