From: NeilBrown <neilb@suse.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/2] fix handling of CPPFLAGS
Date: Mon, 13 Aug 2012 08:13:12 +1000 [thread overview]
Message-ID: <20120813081312.308af64f@notabene.brown> (raw)
In-Reply-To: <1344799457-2478-1-git-send-email-vapier@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
On Sun, 12 Aug 2012 15:24:15 -0400 Mike Frysinger <vapier@gentoo.org> wrote:
> The current Makefile ends up ignoring the system CPPFLAGS settings,
> so make sure we append the variable. Also, the old metadata logic
> has a typo with the flag name.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> Makefile | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 315455b..704b374 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -48,12 +48,10 @@ CWFLAGS += -Wp,-D_FORTIFY_SOURCE=2 -O
> endif
>
> ifdef DEBIAN
> -CPPFLAGS := -DDEBIAN
> -else
> -CPPFLAGS :=
> +CPPFLAGS += -DDEBIAN
> endif
> ifdef DEFAULT_OLD_METADATA
> - CPPFLAG += -DDEFAULT_OLD_METADATA
> + CPPFLAGS += -DDEFAULT_OLD_METADATA
> DEFAULT_METADATA=0.90
> else
> DEFAULT_METADATA=1.2
Applied,
thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-08-12 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-12 19:24 [PATCH 1/2] fix handling of CPPFLAGS Mike Frysinger
2012-08-12 19:24 ` [PATCH 2/2] mdassemble: split dietlibc logic into dedicated target Mike Frysinger
2012-08-12 22:13 ` NeilBrown
2012-08-12 22:13 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813081312.308af64f@notabene.brown \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).