From: NeilBrown <neilb@suse.de>
To: Lukasz Dorau <lukasz.dorau@intel.com>
Cc: linux-raid@vger.kernel.org, maciej.patelczyk@intel.com,
ed.ciechanowski@intel.com, Jacek.Danecki@intel.com
Subject: Re: [PATCH] Manage.c: fix make everything compilation error
Date: Tue, 14 Aug 2012 10:00:52 +1000 [thread overview]
Message-ID: <20120814100052.0f991e9d@notabene.brown> (raw)
In-Reply-To: <20120813095619.21893.87478.stgit@gklab-128-085.igk.intel.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On Mon, 13 Aug 2012 11:56:19 +0200 Lukasz Dorau <lukasz.dorau@intel.com>
wrote:
> This patch fixes the following make everything compilation error:
> Manage.c: In function ‘Manage_add’:
> Manage.c:538: error: ‘dev_st’ may be used uninitialized in this function
> make: *** [mdadm.Os] Error 1
>
> Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
> Manage.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Manage.c b/Manage.c
> index d5fc974..f83af65 100644
> --- a/Manage.c
> +++ b/Manage.c
> @@ -535,7 +535,7 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv,
> char *update, unsigned long rdev, unsigned long long array_size)
> {
> unsigned long long ldsize;
> - struct supertype *dev_st;
> + struct supertype *dev_st = NULL;
> int j;
> mdu_disk_info_t disc;
>
applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-08-14 0:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 9:56 [PATCH] Manage.c: fix make everything compilation error Lukasz Dorau
2012-08-14 0:00 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814100052.0f991e9d@notabene.brown \
--to=neilb@suse.de \
--cc=Jacek.Danecki@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=lukasz.dorau@intel.com \
--cc=maciej.patelczyk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).