From: "Jianpeng Ma" <majianpeng@gmail.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: [PATCH] md: Add two chances to update sync/recovery checkpoint
Date: Sat, 15 Sep 2012 16:59:34 +0800 [thread overview]
Message-ID: <201209151659317342260@gmail.com> (raw)
According commit 97e4f42d62badb0f9fbc27c013e89,it has 16 times to update
checkpoint of sync/recovery in func md_do_sync().
Because the the size of HDD became larger,the time of sync/recovery may
taken long times.So the 1/16 of time maybe half hour or more.
So it should add chance to update checkpoint.
There are places which can update checkpoint in md_do_sync.
1: If call cond_resched and really sched
2: If curr_speed is larger than max_sync_spedd
If above conditions are ok, we can try to update checkpoint.
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
drivers/md/md.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 3f6203a..c7993d6 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -7496,7 +7496,14 @@ void md_do_sync(struct mddev *mddev)
* about not overloading the IO subsystem. (things like an
* e2fsck being done on the RAID array should execute fast)
*/
- cond_resched();
+ if (cond_resched())
+ if (!test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery) &&
+ mddev->curr_resync_completed != j &&
+ atomic_read(&mddev->recovery_active) == 0) {
+ mddev->curr_resync_completed = j;
+ set_bit(MD_CHANGE_CLEAN, &mddev->flags);
+ sysfs_notify(&mddev->kobj, NULL, "sync_completed");
+ }
currspeed = ((unsigned long)(io_sectors-mddev->resync_mark_cnt))/2
/((jiffies-mddev->resync_mark)/HZ +1) +1;
@@ -7505,6 +7512,13 @@ void md_do_sync(struct mddev *mddev)
if ((currspeed > speed_max(mddev)) ||
!is_mddev_idle(mddev, 0)) {
msleep(500);
+ if (!test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery) &&
+ mddev->curr_resync_completed != j &&
+ atomic_read(&mddev->recovery_active) == 0) {
+ mddev->curr_resync_completed = j;
+ set_bit(MD_CHANGE_CLEAN, &mddev->flags);
+ sysfs_notify(&mddev->kobj, NULL, "sync_completed");
+ }
goto repeat;
}
}
--
1.7.9.5
next reply other threads:[~2012-09-15 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 8:59 Jianpeng Ma [this message]
2012-09-20 3:36 ` [PATCH] md: Add two chances to update sync/recovery checkpoint NeilBrown
2012-09-20 6:14 ` Jianpeng Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209151659317342260@gmail.com \
--to=majianpeng@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).