From: NeilBrown <neilb@suse.de>
To: Lukasz Dorau <lukasz.dorau@intel.com>
Cc: linux-raid@vger.kernel.org, maciej.patelczyk@intel.com,
ed.ciechanowski@intel.com, Jacek.Danecki@intel.com
Subject: Re: [PATCH] fix: imsm: re-enable size expansion to the max value
Date: Thu, 20 Sep 2012 12:32:08 +1000 [thread overview]
Message-ID: <20120920123208.2c8059aa@notabene.brown> (raw)
In-Reply-To: <20120914140408.18473.68610.stgit@gklab-128-085.igk.intel.com>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On Fri, 14 Sep 2012 16:04:08 +0200 Lukasz Dorau <lukasz.dorau@intel.com>
wrote:
> Size expansion to the 'max' value has been broken since
> the following patch:
>
> commit d04f65f48c93e7e57cc3c1d70dd07d094dece717
> Change the values for "max size" from -1 to 1.
>
> This patch re-enables it.
>
> Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
> super-intel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index d11eabd..1d36613 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -9737,7 +9737,7 @@ enum imsm_reshape_type imsm_analyze_change(struct supertype *st,
> */
> current_size = info.custom_array_size / data_disks;
>
> - if (geo->size > 0) {
> + if ((geo->size > 0) && (geo->size != MAX_SIZE)) {
> /* align component size
> */
> geo->size = imsm_component_size_aligment_check(
Applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2012-09-20 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 14:04 [PATCH] fix: imsm: re-enable size expansion to the max value Lukasz Dorau
2012-09-20 2:32 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920123208.2c8059aa@notabene.brown \
--to=neilb@suse.de \
--cc=Jacek.Danecki@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=lukasz.dorau@intel.com \
--cc=maciej.patelczyk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).