* [PATCH] fix: imsm: re-enable size expansion to the max value
@ 2012-09-14 14:04 Lukasz Dorau
2012-09-20 2:32 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Lukasz Dorau @ 2012-09-14 14:04 UTC (permalink / raw)
To: neilb; +Cc: linux-raid, maciej.patelczyk, ed.ciechanowski, Jacek.Danecki
Size expansion to the 'max' value has been broken since
the following patch:
commit d04f65f48c93e7e57cc3c1d70dd07d094dece717
Change the values for "max size" from -1 to 1.
This patch re-enables it.
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
---
super-intel.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/super-intel.c b/super-intel.c
index d11eabd..1d36613 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -9737,7 +9737,7 @@ enum imsm_reshape_type imsm_analyze_change(struct supertype *st,
*/
current_size = info.custom_array_size / data_disks;
- if (geo->size > 0) {
+ if ((geo->size > 0) && (geo->size != MAX_SIZE)) {
/* align component size
*/
geo->size = imsm_component_size_aligment_check(
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fix: imsm: re-enable size expansion to the max value
2012-09-14 14:04 [PATCH] fix: imsm: re-enable size expansion to the max value Lukasz Dorau
@ 2012-09-20 2:32 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2012-09-20 2:32 UTC (permalink / raw)
To: Lukasz Dorau; +Cc: linux-raid, maciej.patelczyk, ed.ciechanowski, Jacek.Danecki
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On Fri, 14 Sep 2012 16:04:08 +0200 Lukasz Dorau <lukasz.dorau@intel.com>
wrote:
> Size expansion to the 'max' value has been broken since
> the following patch:
>
> commit d04f65f48c93e7e57cc3c1d70dd07d094dece717
> Change the values for "max size" from -1 to 1.
>
> This patch re-enables it.
>
> Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
> super-intel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index d11eabd..1d36613 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -9737,7 +9737,7 @@ enum imsm_reshape_type imsm_analyze_change(struct supertype *st,
> */
> current_size = info.custom_array_size / data_disks;
>
> - if (geo->size > 0) {
> + if ((geo->size > 0) && (geo->size != MAX_SIZE)) {
> /* align component size
> */
> geo->size = imsm_component_size_aligment_check(
Applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-20 2:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-14 14:04 [PATCH] fix: imsm: re-enable size expansion to the max value Lukasz Dorau
2012-09-20 2:32 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).