From: "Jianpeng Ma" <majianpeng@gmail.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: [PATCH] raid5: fix possible oops in add_stripe_bio when enable pr_debug
Date: Thu, 20 Sep 2012 14:34:00 +0800 [thread overview]
Message-ID: <2012092014334148441317@gmail.com> (raw)
In func add_stripe_bio:
>> .....
>> bip = &sh->dev[dd_idx].toread;
>> ......
>>spin_unlock_irq(&sh->stripe_lock);
>> pr_debug("added bi b#%llu to stripe s#%llu, disk %d.\n",
>> (unsigned long long)(*bip)->bi_sector,
>> (unsigned long long)sh->sector, dd_idx);
After spin_unlock_irq, this thread scheded and toread may become null.
So it will be oops.
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
drivers/md/raid5.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index adda94d..f172b1e 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -2356,6 +2356,7 @@ static int add_stripe_bio(struct stripe_head *sh, struct bio *bi, int dd_idx, in
struct bio **bip;
struct r5conf *conf = sh->raid_conf;
int firstwrite=0;
+ sector_t sector = bi->bi_sector;
pr_debug("adding bi b#%llu to stripe s#%llu\n",
(unsigned long long)bi->bi_sector,
@@ -2406,7 +2407,7 @@ static int add_stripe_bio(struct stripe_head *sh, struct bio *bi, int dd_idx, in
spin_unlock_irq(&sh->stripe_lock);
pr_debug("added bi b#%llu to stripe s#%llu, disk %d.\n",
- (unsigned long long)(*bip)->bi_sector,
+ (unsigned long long)sector,
(unsigned long long)sh->sector, dd_idx);
if (conf->mddev->bitmap && firstwrite) {
--
1.7.9.5
next reply other threads:[~2012-09-20 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 6:34 Jianpeng Ma [this message]
2012-09-20 6:47 ` [PATCH] raid5: fix possible oops in add_stripe_bio when enable pr_debug NeilBrown
2012-09-20 7:17 ` Jianpeng Ma
2012-09-25 6:45 ` NeilBrown
2012-09-25 6:50 ` Jianpeng Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2012092014334148441317@gmail.com \
--to=majianpeng@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).