From: "Jianpeng Ma" <majianpeng@gmail.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: Re: [PATCH] raid5: fix possible oops in add_stripe_bio when enable pr_debug
Date: Tue, 25 Sep 2012 14:50:25 +0800 [thread overview]
Message-ID: <201209251450227812256@gmail.com> (raw)
In-Reply-To: 20120925164546.3882f076@notabene.brown
On 2012-09-25 14:45 NeilBrown <neilb@suse.de> Wrote:
>On Thu, 20 Sep 2012 15:17:54 +0800 "Jianpeng Ma" <majianpeng@gmail.com> wrote:
>
>> On 2012-09-20 14:47 NeilBrown <neilb@suse.de> Wrote:
>> >On Thu, 20 Sep 2012 14:34:00 +0800 "Jianpeng Ma" <majianpeng@gmail.com> wrote:
>> >
>> >> In func add_stripe_bio:
>> >> >> .....
>> >> >> bip = &sh->dev[dd_idx].toread;
>> >> >> ......
>> >> >>spin_unlock_irq(&sh->stripe_lock);
>> >>
>> >> >> pr_debug("added bi b#%llu to stripe s#%llu, disk %d.\n",
>> >> >> (unsigned long long)(*bip)->bi_sector,
>> >> >> (unsigned long long)sh->sector, dd_idx);
>> >> After spin_unlock_irq, this thread scheded and toread may become null.
>> >> So it will be oops.
>> >>
>> >> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
>> >> ---
>> >> drivers/md/raid5.c | 3 ++-
>> >> 1 file changed, 2 insertions(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
>> >> index adda94d..f172b1e 100644
>> >> --- a/drivers/md/raid5.c
>> >> +++ b/drivers/md/raid5.c
>> >> @@ -2356,6 +2356,7 @@ static int add_stripe_bio(struct stripe_head *sh, struct bio *bi, int dd_idx, in
>> >> struct bio **bip;
>> >> struct r5conf *conf = sh->raid_conf;
>> >> int firstwrite=0;
>> >> + sector_t sector = bi->bi_sector;
>> >>
>> >> pr_debug("adding bi b#%llu to stripe s#%llu\n",
>> >> (unsigned long long)bi->bi_sector,
>> >> @@ -2406,7 +2407,7 @@ static int add_stripe_bio(struct stripe_head *sh, struct bio *bi, int dd_idx, in
>> >> spin_unlock_irq(&sh->stripe_lock);
>> >>
>> >> pr_debug("added bi b#%llu to stripe s#%llu, disk %d.\n",
>> >> - (unsigned long long)(*bip)->bi_sector,
>> >> + (unsigned long long)sector,
>> >> (unsigned long long)sh->sector, dd_idx);
>> >>
>> >> if (conf->mddev->bitmap && firstwrite) {
>> >
>> >
>> >how about we just move the spin_unlock_irq after the pr_debug??
>> >
>> ah! Why are you think ? my method only add a parameter.
>
>Yes.
>
>> BTW, in func handle_failed_stripe:
>> >>if (!test_bit(R5_Wantfill, &sh->dev[i].flags) &&
>> >> (!test_bit(R5_Insync, &sh->dev[i].flags) ||
>> >> test_bit(R5_ReadError, &sh->dev[i].flags))) {
>> >> bi = sh->dev[i].toread;
>> >> sh->dev[i].toread = NULL;
>> >> if (test_and_clear_bit(R5_Overlap, &sh->dev[i].flags))
>> >> wake_up(&conf->wait_for_overlap);
>> Why use stripe_lock to protect toread?
>
>I assume you mean that we should be holding the lock to protect toread, but
>we aren't.
>I've queued a patch to fix that.
>
Hi,
Last Saturday, i sent a patch-set which contained a patch which fix this bug.
You can check your mail!
Thanks!
>Thanks.
>NeilBrown
>
>
>>
>> Thanks!
>
>
prev parent reply other threads:[~2012-09-25 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 6:34 [PATCH] raid5: fix possible oops in add_stripe_bio when enable pr_debug Jianpeng Ma
2012-09-20 6:47 ` NeilBrown
2012-09-20 7:17 ` Jianpeng Ma
2012-09-25 6:45 ` NeilBrown
2012-09-25 6:50 ` Jianpeng Ma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209251450227812256@gmail.com \
--to=majianpeng@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).