linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/3] Replace --no-error by --keep-going
@ 2012-10-20 16:04 Gilles Espinasse
  2012-10-21 22:11 ` NeilBrown
  0 siblings, 1 reply; 2+ messages in thread
From: Gilles Espinasse @ 2012-10-20 16:04 UTC (permalink / raw)
  To: linux-raid, neilb; +Cc: Gilles Espinasse

Signed-off-by: Gilles Espinasse <g.esp@free.fr>

Suggest to replace by the option name that 'make' use.
no error is only a developper hope.
---
 test |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test b/test
index 8339d06..c5b1982 100755
--- a/test
+++ b/test
@@ -252,7 +252,7 @@ do_help() {
   echo "    --disable-multipath         Disable any tests involving multipath"
   echo "    --logdir=<directory>        Directory to save logfiles in"
   echo "    --save-logs                 Save all logs in <logdir>"
-  echo "    --no-error                  Don't stop on error, ie. run all tests"
+  echo "    --keep-going                Don't stop on error, ie. run all tests"
   echo "    setup                       Setup test environment and exit"
   echo "    cleanup                     Cleanup test environment"
   echo "    <prefix>                    Run tests with <prefix>"
@@ -289,7 +289,7 @@ parse_args() {
 	fi
       fi
       ;;
-    --no-error)
+    --keep-going)
       exitonerror=0
       ;;
     --disable-multipath)
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/3] Replace --no-error by --keep-going
  2012-10-20 16:04 [PATCH 3/3] Replace --no-error by --keep-going Gilles Espinasse
@ 2012-10-21 22:11 ` NeilBrown
  0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2012-10-21 22:11 UTC (permalink / raw)
  To: Gilles Espinasse; +Cc: linux-raid

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

On Sat, 20 Oct 2012 18:04:14 +0200 Gilles Espinasse <g.esp@free.fr> wrote:

> Signed-off-by: Gilles Espinasse <g.esp@free.fr>
> 
> Suggest to replace by the option name that 'make' use.
> no error is only a developper hope.
> ---
>  test |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test b/test
> index 8339d06..c5b1982 100755
> --- a/test
> +++ b/test
> @@ -252,7 +252,7 @@ do_help() {
>    echo "    --disable-multipath         Disable any tests involving multipath"
>    echo "    --logdir=<directory>        Directory to save logfiles in"
>    echo "    --save-logs                 Save all logs in <logdir>"
> -  echo "    --no-error                  Don't stop on error, ie. run all tests"
> +  echo "    --keep-going                Don't stop on error, ie. run all tests"
>    echo "    setup                       Setup test environment and exit"
>    echo "    cleanup                     Cleanup test environment"
>    echo "    <prefix>                    Run tests with <prefix>"
> @@ -289,7 +289,7 @@ parse_args() {
>  	fi
>        fi
>        ;;
> -    --no-error)
> +    --keep-going)
>        exitonerror=0
>        ;;
>      --disable-multipath)

Applied, thanks ... though I kept "--no-error" as an alternative (it still
works, but isn't listed in the help).

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-21 22:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-20 16:04 [PATCH 3/3] Replace --no-error by --keep-going Gilles Espinasse
2012-10-21 22:11 ` NeilBrown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).