From: majianpeng <majianpeng@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: Shaohua Li <shli@kernel.org>, linux-raid <linux-raid@vger.kernel.org>
Subject: About re-adding disk to raid which havent' bitmap
Date: Tue, 23 Oct 2012 10:40:28 +0800 [thread overview]
Message-ID: <2012102310402085755311@gmail.com> (raw)
Hi Neil,
At present, re-add operation only useful raid which had bitmap.
Through the git-log, i found the commit:
>commit 07d84d109d8beedd68df9da2e4e9f25c8217e7fb
>Author: NeilBrown <neilb@suse.de>
>Date: Mon Jun 26 00:27:56 2006 -0700
> [PATCH] md: Allow re-add to work on array without bitmaps
> When an array has a bitmap, a device can be removed and re-added and only
> blocks changes since the removal (as recorded in the bitmap) will be resynced.
> It should be possible to do a similar thing to arrays without bitmaps. i.e.
> if a device is removed and re-added and *no* changes have been made in the
> interim, then the add should not require a resync.
> This patch allows that option. This means that when assembling an array one
> device at a time (e.g. during device discovery) the array can be enabled
> read-only as soon as enough devices are available, but extra devices can still
> be added without causing a resync.
Q1:why you think " if a device is removed and re-added and *no* changes have been made in the
interim, then the add should not require a resync."?
Q2: Whether intentional or not, remove the device will cause the event of raid changed.So for raid which haven't bitmap,
re-add must failed and only added which cause recovery.
For ssd, recovery will write whole disk.But if user used re-add parameter, he/she know the different of data.So i think it should do something for this.
Thanks!
Jianpeng
reply other threads:[~2012-10-23 2:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2012102310402085755311@gmail.com \
--to=majianpeng@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).