* Commit "db91ff55bdf06736b" using curr_resync_completed instead of curr_resync when interrupted the resync operation @ 2012-10-25 6:16 majianpeng 2012-10-28 22:47 ` NeilBrown 0 siblings, 1 reply; 2+ messages in thread From: majianpeng @ 2012-10-25 6:16 UTC (permalink / raw) To: NeilBrown; +Cc: linux-raid Hi Neil, >commit db91ff55bdf06736b849afc1b1fce5763bbb8d5d > 1/ If a resync is aborted we should record how far we got > (recovery_cp) the last request that we know has completed > (->curr_resync_completed) rather than the last request that was > submitted (->curr_resync). If resync operation interrupted,it will call: > wait_event(mddev->recovery_wait, !atomic_read(&mddev->recovery_active)); So the curr_resync must be complete. Using curr_resync is safe. -------------- majianpeng ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Commit "db91ff55bdf06736b" using curr_resync_completed instead of curr_resync when interrupted the resync operation 2012-10-25 6:16 Commit "db91ff55bdf06736b" using curr_resync_completed instead of curr_resync when interrupted the resync operation majianpeng @ 2012-10-28 22:47 ` NeilBrown 0 siblings, 0 replies; 2+ messages in thread From: NeilBrown @ 2012-10-28 22:47 UTC (permalink / raw) To: majianpeng; +Cc: linux-raid [-- Attachment #1: Type: text/plain, Size: 989 bytes --] On Thu, 25 Oct 2012 14:16:02 +0800 majianpeng <majianpeng@gmail.com> wrote: > Hi Neil, > >commit db91ff55bdf06736b849afc1b1fce5763bbb8d5d > > 1/ If a resync is aborted we should record how far we got > > (recovery_cp) the last request that we know has completed > > (->curr_resync_completed) rather than the last request that was > > submitted (->curr_resync). > If resync operation interrupted,it will call: > > wait_event(mddev->recovery_wait, !atomic_read(&mddev->recovery_active)); > So the curr_resync must be complete. Using curr_resync is safe. > -------------- > majianpeng I must have had a reason for that patch. Unfortunately the change log isn't the best... If the resync aborted cleanly with no errors (e.g. while stopping the array), then I agree. However if some read error was involved I'm not so sure. I would have to examine the code closely, which I don't feel up to at the moment (plenty of other things to do). NeilBrown [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 828 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-28 22:47 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-10-25 6:16 Commit "db91ff55bdf06736b" using curr_resync_completed instead of curr_resync when interrupted the resync operation majianpeng 2012-10-28 22:47 ` NeilBrown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).