From: NeilBrown <neilb@suse.de>
To: Shaohua Li <shli@kernel.org>
Cc: linux RAID <linux-raid@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, lkml <linux-kernel@vger.kernel.org>
Subject: Problem with DISCARD and RAID5
Date: Thu, 1 Nov 2012 17:38:54 +1100 [thread overview]
Message-ID: <20121101173854.62061307@notabene.brown> (raw)
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
Hi Shaohua,
I've been doing some testing and discovered a problem with your discard
support for RAID5.
The code in blkdev_issue_discard assumes that the 'granularity' is a power
of 2, and for example subtracts 1 to get a mask.
However RAID5 sets the granularity to be the stripe size which often is not
a power of two. When this happens you can easily get into an infinite loop.
I suspect that to make this work properly, blkdev_issue_discard will need to
be changed to allow 'granularity' to be an arbitrary value.
When it is a power of two, the current masking can be used.
When it is anything else, it will need to use sector_div().
Could you look into this please?
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next reply other threads:[~2012-11-01 6:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 6:38 NeilBrown [this message]
2012-11-02 1:40 ` Problem with DISCARD and RAID5 Shaohua Li
2012-11-05 21:48 ` Dave Chinner
2012-11-06 8:06 ` Jens Axboe
2012-11-07 5:02 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101173854.62061307@notabene.brown \
--to=neilb@suse.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).