From: Mike Snitzer <snitzer@redhat.com>
To: majianpeng <majianpeng@gmail.com>
Cc: agk <agk@redhat.com>, linux-raid <linux-raid@vger.kernel.org>,
dm-devel <dm-devel@redhat.com>
Subject: Re: [PATCH 1/3] md:Add a func 'dm_md_stop' for dm-raid to clear up md resources.
Date: Thu, 15 Nov 2012 08:52:41 -0500 [thread overview]
Message-ID: <20121115135241.GB15279@redhat.com> (raw)
In-Reply-To: <201211151951429245011@gmail.com>
On Thu, Nov 15 2012 at 6:51am -0500,
majianpeng <majianpeng@gmail.com> wrote:
> >On Thu, Nov 15, 2012 at 04:46:59PM +0800, majianpeng wrote:
> >> So add a func dm_md_stop to clear up resource.
> >
> >> +++ b/drivers/md/md.c
> >
> >> +void dm_md_stop(struct mddev *mddev)
> >> +{
> >> + md_stop(mddev);
> >> + bitmap_destroy(mddev);
> >> + if (mddev->bio_set)
> >> + bioset_free(mddev->bio_set);
> >> +}
> >> +EXPORT_SYMBOL_GPL(dm_md_stop);
> >
> >Let's not put a function with a dm_ prefix in an md file?
> >
> >Alasdair
> >
> Can you give me a hint? My thought is this func only by dm to call and there was a md_stop already?
> I firstly want to add those statements in dm driver like md_stop rather than a func include those.
> But i think dm don't know to much.
Nmae it mddev_stop_and_cleanup?
prev parent reply other threads:[~2012-11-15 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 8:46 [PATCH 1/3] md:Add a func 'dm_md_stop' for dm-raid to clear up md resources majianpeng
2012-11-15 11:45 ` Alasdair G Kergon
2012-11-15 11:51 ` majianpeng
2012-11-15 13:52 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121115135241.GB15279@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=majianpeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).