[md:for-linus 7/8] drivers/md/md.c:5297:6: sparse: symbol '__md_stop' was not declared. Should it be static?

[md:for-linus 7/8] drivers/md/md.c:5297:6: sparse: symbol '__md_stop' was not declared. Should it be static?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

tree:   git://neil.brown.name/md for-linus
head:   879d63a5d4cc36ff804a9cf0de2c092dd538fa45
commit: fceef26b94e8507f33e28741f755c010de052042 [7/8] md: make sure everything is freed when dm-raid stops an array.


sparse warnings:

drivers/md/md.c:1553:34: sparse: cast to restricted __le64
drivers/md/md.c:1823:40: sparse: incorrect type in assignment (different base types)
drivers/md/md.c:1823:40:    expected unsigned long long [unsigned] [long] [long long] [usertype] <noident>
drivers/md/md.c:1823:40:    got restricted __le64 [usertype] <noident>
drivers/md/md.c:1898:26: sparse: incorrect type in assignment (different base types)
drivers/md/md.c:1898:26:    expected restricted __le64 [usertype] super_offset
drivers/md/md.c:1898:26:    got unsigned long long [unsigned] [usertype] sb_start
+ drivers/md/md.c:5297:6: sparse: symbol '__md_stop' was not declared. Should it be static?

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend         Open Source Technology Center
Fengguang Wu, Yuanhan Liu                              Intel Corporation

[-- Attachment #2: make-it-static-fceef26.diff --]
[-- Type: text/x-diff, Size: 357 bytes --]

diff --git a/drivers/md/md.c b/drivers/md/md.c
index a8cf4be..6120071 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5294,7 +5294,7 @@ void md_stop_writes(struct mddev *mddev)
 }
 EXPORT_SYMBOL_GPL(md_stop_writes);
 
-void __md_stop(struct mddev *mddev)
+static void __md_stop(struct mddev *mddev)
 {
 	mddev->ready = 0;
 	mddev->pers->stop(mddev);

Re: [md:for-linus 7/8] drivers/md/md.c:5297:6: sparse: symbol '__md_stop' was not declared. Should it be static?

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

On Tue, 20 Nov 2012 16:25:21 +0800 kbuild test robot <fengguang.wu@intel.com>
wrote:

> tree:   git://neil.brown.name/md for-linus
> head:   879d63a5d4cc36ff804a9cf0de2c092dd538fa45
> commit: fceef26b94e8507f33e28741f755c010de052042 [7/8] md: make sure everything is freed when dm-raid stops an array.
> 
> 
> sparse warnings:
> 
> drivers/md/md.c:1553:34: sparse: cast to restricted __le64
> drivers/md/md.c:1823:40: sparse: incorrect type in assignment (different base types)
> drivers/md/md.c:1823:40:    expected unsigned long long [unsigned] [long] [long long] [usertype] <noident>
> drivers/md/md.c:1823:40:    got restricted __le64 [usertype] <noident>
> drivers/md/md.c:1898:26: sparse: incorrect type in assignment (different base types)
> drivers/md/md.c:1898:26:    expected restricted __le64 [usertype] super_offset
> drivers/md/md.c:1898:26:    got unsigned long long [unsigned] [usertype] sb_start
> + drivers/md/md.c:5297:6: sparse: symbol '__md_stop' was not declared. Should it be static?
> 
> Please consider folding the attached diff :-)

Wow!  What wonderful service.

Attached diff has been folded in.

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [md:for-linus 7/8] drivers/md/md.c:5297:6: sparse: symbol '__md_stop' was not declared. Should it be static?

[Fengguang Wu]

On Tue, Nov 20, 2012 at 07:46:14PM +1100, NeilBrown wrote:
> On Tue, 20 Nov 2012 16:25:21 +0800 kbuild test robot <fengguang.wu@intel.com>
> wrote:
> 
> > tree:   git://neil.brown.name/md for-linus
> > head:   879d63a5d4cc36ff804a9cf0de2c092dd538fa45
> > commit: fceef26b94e8507f33e28741f755c010de052042 [7/8] md: make sure everything is freed when dm-raid stops an array.
> > 
> > 
> > sparse warnings:
> > 
> > drivers/md/md.c:1553:34: sparse: cast to restricted __le64
> > drivers/md/md.c:1823:40: sparse: incorrect type in assignment (different base types)
> > drivers/md/md.c:1823:40:    expected unsigned long long [unsigned] [long] [long long] [usertype] <noident>
> > drivers/md/md.c:1823:40:    got restricted __le64 [usertype] <noident>
> > drivers/md/md.c:1898:26: sparse: incorrect type in assignment (different base types)
> > drivers/md/md.c:1898:26:    expected restricted __le64 [usertype] super_offset
> > drivers/md/md.c:1898:26:    got unsigned long long [unsigned] [usertype] sb_start
> > + drivers/md/md.c:5297:6: sparse: symbol '__md_stop' was not declared. Should it be static?
> > 
> > Please consider folding the attached diff :-)
> 
> Wow!  What wonderful service.
> 
> Attached diff has been folded in.

Thank you! :)

Regards,
Fengguang