From: Alasdair G Kergon <agk@redhat.com>
To: Jonathan Brassow <jbrassow@redhat.com>
Cc: linux-raid@vger.kernel.org, neilb@suse.de, agk@redhat.com
Subject: Re: [PATCH] DM RAID: Ensure the bitmap region_size is a power of 2
Date: Wed, 12 Dec 2012 16:10:18 +0000 [thread overview]
Message-ID: <20121212161018.GF12788@agk.fab.redhat.com> (raw)
In-Reply-To: <1355324012.26828.9.camel@f16>
On Wed, Dec 12, 2012 at 08:53:32AM -0600, Jon Brassow wrote:
> This is probably a better way to do it...
Indeed. I'll pick this one up.
> DM RAID: Ensure the bitmap region_size is a power of 2
>
> If the user does not supply a region_size, a reasonable size is computed
> automatically. However, region_size needs to be a power of 2 and the
> code was not properly ensuring that.
And this is just a cleanup patch: to provide a controlled error message
here, rather than triggering a controlled error inside the md code
later.
Alasdair
prev parent reply other threads:[~2012-12-12 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 21:37 [PATCH] DM RAID: Ensure the bitmap region_size is a power of 2 Jonathan Brassow
2012-12-11 21:49 ` Alasdair G Kergon
2012-12-12 14:53 ` Jonathan Brassow
2012-12-12 16:10 ` Alasdair G Kergon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121212161018.GF12788@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=jbrassow@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).