From: Alasdair G Kergon <agk@redhat.com>
To: Tim Gardner <tim.gardner@canonical.com>
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH linux-next] DM RAID: validate_raid_redundancy: Silence uninitialized variable warning
Date: Thu, 21 Feb 2013 13:19:31 +0000 [thread overview]
Message-ID: <20130221131931.GA29577@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <1361392278-59767-1-git-send-email-tim.gardner@canonical.com>
On Wed, Feb 20, 2013 at 01:31:18PM -0700, Tim Gardner wrote:
> drivers/md/dm-raid.c: In function 'raid_ctr':
> drivers/md/dm-raid.c:453:53: warning: 'rebuilds_per_group' may be used uninitialized in this function [-Wuninitialized]
> drivers/md/dm-raid.c:383:11: note: 'rebuilds_per_group' was declared here
> It appears unlikely that rebuilds_per_group could be used before set, but set
> it to 0 anyways just to shutup GCC.
Looks bogus to me.
uninitialized_var() please.
Alasdair
next prev parent reply other threads:[~2013-02-21 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 20:31 [PATCH linux-next] DM RAID: validate_raid_redundancy: Silence uninitialized variable warning Tim Gardner
2013-02-20 22:16 ` Paul Menzel
2013-02-20 22:18 ` Paul Menzel
2013-02-20 22:37 ` NeilBrown
2013-02-21 13:19 ` Alasdair G Kergon [this message]
2013-02-21 14:50 ` [PATCH linux-next v2] " Tim Gardner
2013-06-13 15:30 ` Tommi Rantala
2013-06-13 16:00 ` Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221131931.GA29577@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).