* [PATCH 2/4] md/raid5: Tune judgements order.
@ 2013-02-28 7:50 majianpeng
2013-03-04 1:49 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: majianpeng @ 2013-02-28 7:50 UTC (permalink / raw)
To: NeilBrown; +Cc: linux-raid
To reduce the unnecessary function call in certain condtitions,it should
tune judgements order.
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
drivers/md/raid5.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 59c0569..bd49623 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -4665,9 +4665,10 @@ static inline sector_t sync_request(struct mddev *mddev, sector_t sector_nr, int
*skipped = 1;
return rv;
}
- if (!bitmap_start_sync(mddev->bitmap, sector_nr, &sync_blocks, 1) &&
- !test_bit(MD_RECOVERY_REQUESTED, &mddev->recovery) &&
- !conf->fullsync && sync_blocks >= STRIPE_SECTORS) {
+ if (!test_bit(MD_RECOVERY_REQUESTED, &mddev->recovery) &&
+ !conf->fullsync &&
+ !bitmap_start_sync(mddev->bitmap, sector_nr, &sync_blocks, 1) &&
+ sync_blocks >= STRIPE_SECTORS) {
/* we can skip this block, and probably more */
sync_blocks /= STRIPE_SECTORS;
*skipped = 1;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/4] md/raid5: Tune judgements order.
2013-02-28 7:50 [PATCH 2/4] md/raid5: Tune judgements order majianpeng
@ 2013-03-04 1:49 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2013-03-04 1:49 UTC (permalink / raw)
To: majianpeng; +Cc: linux-raid
[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]
On Thu, 28 Feb 2013 15:50:47 +0800 majianpeng <majianpeng@gmail.com> wrote:
> To reduce the unnecessary function call in certain condtitions,it should
> tune judgements order.
>
> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> ---
> drivers/md/raid5.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 59c0569..bd49623 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -4665,9 +4665,10 @@ static inline sector_t sync_request(struct mddev *mddev, sector_t sector_nr, int
> *skipped = 1;
> return rv;
> }
> - if (!bitmap_start_sync(mddev->bitmap, sector_nr, &sync_blocks, 1) &&
> - !test_bit(MD_RECOVERY_REQUESTED, &mddev->recovery) &&
> - !conf->fullsync && sync_blocks >= STRIPE_SECTORS) {
> + if (!test_bit(MD_RECOVERY_REQUESTED, &mddev->recovery) &&
> + !conf->fullsync &&
> + !bitmap_start_sync(mddev->bitmap, sector_nr, &sync_blocks, 1) &&
> + sync_blocks >= STRIPE_SECTORS) {
> /* we can skip this block, and probably more */
> sync_blocks /= STRIPE_SECTORS;
> *skipped = 1;
applied, thanks (after fixing up the formatting).
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-04 1:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-28 7:50 [PATCH 2/4] md/raid5: Tune judgements order majianpeng
2013-03-04 1:49 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).