* [PATCH] md: use set_bit_le and clear_bit_le
@ 2013-03-02 14:35 Akinobu Mita
2013-03-04 0:58 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2013-03-02 14:35 UTC (permalink / raw)
To: linux-kernel, akpm; +Cc: Akinobu Mita, Neil Brown, linux-raid
The value returned by test_and_set_bit_le() drivers/md/bitmap.c is not used.
So just use set_bit_le(). The same goes for test_and_clear_bit_le().
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
---
drivers/md/bitmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index 4fd9d6a..5a2c754 100644
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -846,7 +846,7 @@ static void bitmap_file_set_bit(struct bitmap *bitmap, sector_t block)
if (test_bit(BITMAP_HOSTENDIAN, &bitmap->flags))
set_bit(bit, kaddr);
else
- test_and_set_bit_le(bit, kaddr);
+ set_bit_le(bit, kaddr);
kunmap_atomic(kaddr);
pr_debug("set file bit %lu page %lu\n", bit, page->index);
/* record page number so it gets flushed to disk when unplug occurs */
@@ -868,7 +868,7 @@ static void bitmap_file_clear_bit(struct bitmap *bitmap, sector_t block)
if (test_bit(BITMAP_HOSTENDIAN, &bitmap->flags))
clear_bit(bit, paddr);
else
- test_and_clear_bit_le(bit, paddr);
+ clear_bit_le(bit, paddr);
kunmap_atomic(paddr);
if (!test_page_attr(bitmap, page->index, BITMAP_PAGE_NEEDWRITE)) {
set_page_attr(bitmap, page->index, BITMAP_PAGE_PENDING);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] md: use set_bit_le and clear_bit_le
2013-03-02 14:35 [PATCH] md: use set_bit_le and clear_bit_le Akinobu Mita
@ 2013-03-04 0:58 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2013-03-04 0:58 UTC (permalink / raw)
To: Akinobu Mita; +Cc: linux-kernel, akpm, linux-raid
[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]
On Sat, 2 Mar 2013 23:35:57 +0900 Akinobu Mita <akinobu.mita@gmail.com>
wrote:
> The value returned by test_and_set_bit_le() drivers/md/bitmap.c is not used.
> So just use set_bit_le(). The same goes for test_and_clear_bit_le().
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Neil Brown <neilb@suse.de>
> Cc: linux-raid@vger.kernel.org
> ---
> drivers/md/bitmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 4fd9d6a..5a2c754 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -846,7 +846,7 @@ static void bitmap_file_set_bit(struct bitmap *bitmap, sector_t block)
> if (test_bit(BITMAP_HOSTENDIAN, &bitmap->flags))
> set_bit(bit, kaddr);
> else
> - test_and_set_bit_le(bit, kaddr);
> + set_bit_le(bit, kaddr);
> kunmap_atomic(kaddr);
> pr_debug("set file bit %lu page %lu\n", bit, page->index);
> /* record page number so it gets flushed to disk when unplug occurs */
> @@ -868,7 +868,7 @@ static void bitmap_file_clear_bit(struct bitmap *bitmap, sector_t block)
> if (test_bit(BITMAP_HOSTENDIAN, &bitmap->flags))
> clear_bit(bit, paddr);
> else
> - test_and_clear_bit_le(bit, paddr);
> + clear_bit_le(bit, paddr);
> kunmap_atomic(paddr);
> if (!test_page_attr(bitmap, page->index, BITMAP_PAGE_NEEDWRITE)) {
> set_page_attr(bitmap, page->index, BITMAP_PAGE_PENDING);
applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-04 0:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-02 14:35 [PATCH] md: use set_bit_le and clear_bit_le Akinobu Mita
2013-03-04 0:58 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).