Re: [BUG][PATCH] Fix: raid1/raid10 md devices leak memory when stopping

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]

On Tue, 16 Apr 2013 20:15:07 +0900 (JST) Hirokazu Takahashi
<taka@valinux.co.jp> wrote:

> Hi.
> 
> Raid1 and raid10 devices leak memory every time they stop.
> This is a patch for linux-3.9.0-rc7 to fix this problem.
> 
> Thanks,
> Hirokazu Takahashi.
> 
> Signed-off-by: Hirokazu Takahashi <taka@valinux.co.jp>
> ---
>  drivers/md/raid1.c  |    1 +
>  drivers/md/raid10.c |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index fd86b37..c055b92 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -2901,6 +2901,7 @@ static int stop(struct mddev *mddev)
>  	if (conf->r1bio_pool)
>  		mempool_destroy(conf->r1bio_pool);
>  	kfree(conf->mirrors);
> +	safe_put_page(conf->tmppage);
>  	kfree(conf->poolinfo);
>  	kfree(conf);
>  	mddev->private = NULL;
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 77b562d..5a1010d 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -3810,6 +3810,7 @@ static int stop(struct mddev *mddev)
>  
>  	if (conf->r10bio_pool)
>  		mempool_destroy(conf->r10bio_pool);
> +	safe_put_page(conf->tmppage);
>  	kfree(conf->mirrors);
>  	kfree(conf);
>  	mddev->private = NULL;

Thanks for the patch!
I've queued it for 3.10-rc

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]