From: NeilBrown <neilb@suse.de>
To: mwilck@arcor.de
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] DDF: fix bug in compare_super_ddf
Date: Wed, 24 Apr 2013 16:34:44 +1000 [thread overview]
Message-ID: <20130424163444.55f8114f@notabene.brown> (raw)
In-Reply-To: <1366740616-7803-1-git-send-email-mwilck@arcor.de>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On Tue, 23 Apr 2013 20:10:16 +0200 mwilck@arcor.de wrote:
> Fix bug in previous patch
> "DDF: compare_super_ddf: merge local info of other superblock"
>
> Just discovered this bug in my last patch set - unfortunately, just after
> you committed it.
Life's like that sometimes :-)
Applied- thanks.
NeilBrown
>
> Signed-off-by: Martin Wilck <mwilck@arcor.de>
> ---
> super-ddf.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/super-ddf.c b/super-ddf.c
> index 455f0f8..ea8439b 100644
> --- a/super-ddf.c
> +++ b/super-ddf.c
> @@ -3514,7 +3514,7 @@ static int compare_super_ddf(struct supertype *st, struct supertype *tst)
>
> vl1->next = first->conflist;
> vl1->block_sizes = NULL;
> - if (vl1->conf.sec_elmnt_count > 1) {
> + if (vl2->conf.sec_elmnt_count > 1) {
> vl1->other_bvds = xcalloc(vl2->conf.sec_elmnt_count - 1,
> sizeof(struct vd_config *));
> } else
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2013-04-24 6:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 23:10 Fixes for DDF test case (race conditions in mdmon) mwilck
2013-03-25 23:11 ` [PATCH 1/8] DDF: __write_ddf_structure: Fix wrong reference to ddf->primary mwilck
2013-03-25 23:11 ` [PATCH 2/8] DDF: __write_init_super_ddf: just use seq number of active header mwilck
2013-03-25 23:11 ` [PATCH 4/8] DDF: add code to debug state changes mwilck
2013-03-25 23:11 ` [PATCH 3/8] DDF: brief_detail_super_ddf: print correct UUID for subarrays mwilck
2013-03-25 23:11 ` [PATCH 8/8] tests/10ddf-create: omit log output check mwilck
2013-03-25 23:11 ` [PATCH 7/8] monitor: treat unreadable array_state as clean mwilck
2013-03-25 23:11 ` [PATCH 5/8] monitor: don't call pselect() on deleted sysfs files mwilck
2013-03-25 23:11 ` [PATCH 6/8] monitor: read_and_act: handle race conditions for resync_start mwilck
2013-04-23 7:15 ` Fixes for DDF test case (race conditions in mdmon) NeilBrown
2013-04-23 17:30 ` Martin Wilck
2013-04-23 18:10 ` [PATCH] DDF: fix bug in compare_super_ddf mwilck
2013-04-24 6:34 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424163444.55f8114f@notabene.brown \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=mwilck@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).