From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar amit mehta Subject: Re: [PATCH] md: bcache: io.c: fix a potential NULL pointer dereference Date: Tue, 28 May 2013 20:01:13 -0400 Message-ID: <20130529000113.GA6648@gmail.com> References: <1369726275-5424-1-git-send-email-gmate.amit@gmail.com> <20130529002041.GC2291@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130529002041.GC2291-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kent Overstreet Cc: neilb-l3A5Bk7waGM@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-raid.ids On Tue, May 28, 2013 at 05:20:41PM -0700, Kent Overstreet wrote: > On Tue, May 28, 2013 at 12:31:15AM -0700, Kumar Amit Mehta wrote: > > bio_alloc_bioset returns NULL on failure. This fix adds a missing check > > for potential NULL pointer dereferencing. > > Whoops, that's definitely a bug. Thanks, applied. > > How'd you find it? Using smatch[1] [1] http://smatch.sourceforge.net/