From: NeilBrown <neilb@suse.de>
To: Joe Lawrence <joe.lawrence@stratus.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Dan Williams <dan.j.williams@gmail.com>,
linux-raid <linux-raid@vger.kernel.org>
Subject: Re: RAID-10 keeps aborting
Date: Thu, 13 Jun 2013 13:11:59 +1000 [thread overview]
Message-ID: <20130613131159.07250e04@notabene.brown> (raw)
In-Reply-To: <alpine.DEB.2.02.1306122242290.22555@jlaw-desktop.mno.stratus.com>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
On Wed, 12 Jun 2013 22:45:08 -0400 (EDT) Joe Lawrence
<joe.lawrence@stratus.com> wrote:
> On Wed, 12 Jun 2013, NeilBrown wrote:
>
> > I've applied that patch below - thanks.
> >
> > NeilBrown
> > >
> > > From b12c24ee0fce802f35263da65d236694b01c99cf Mon Sep 17 00:00:00 2001
> > > From: Joe Lawrence <joe.lawrence@stratus.com>
> > > Date: Fri, 7 Jun 2013 15:25:54 -0400
> > > Subject: [PATCH] raid1: properly set blk_queue_max_write_same_sectors
> > >
> [snip patch]
>
> Hi Neil -- this patch was only to test out what RAID1 would do if the
> blk_queue_max_write_same_sectors were set to enable WRITE SAME. As HPA
> and Martin point out, we should be disabling WRITE SAME for raid1/10 in
> 3.10 / stable for now. Sorry for the confusion.
>
> -- Joe
Ahh - thanks.
the code your patch removes is clearly wrong as chunk size doesn't mean
anything useful for raid1, but as you say we need to actually disable it, so
may as well do that at the same time as removing the error.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2013-06-13 3:11 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 3:57 RAID-10 keeps aborting H. Peter Anvin
2013-06-03 4:05 ` H. Peter Anvin
2013-06-03 5:47 ` Dan Williams
2013-06-03 6:06 ` H. Peter Anvin
2013-06-03 6:14 ` Dan Williams
2013-06-03 6:30 ` H. Peter Anvin
2013-06-03 14:39 ` H. Peter Anvin
2013-06-11 16:47 ` Joe Lawrence
2013-06-11 17:12 ` H. Peter Anvin
2013-06-03 15:47 ` H. Peter Anvin
2013-06-03 16:09 ` Joe Lawrence
2013-06-03 17:22 ` Dan Williams
2013-06-03 17:40 ` H. Peter Anvin
2013-06-03 18:35 ` Martin K. Petersen
2013-06-03 18:38 ` H. Peter Anvin
2013-06-03 18:40 ` H. Peter Anvin
2013-06-03 22:20 ` H. Peter Anvin
2013-06-03 22:34 ` H. Peter Anvin
2013-06-04 15:56 ` Martin K. Petersen
2013-06-03 23:19 ` H. Peter Anvin
2013-06-04 15:39 ` Joe Lawrence
2013-06-04 15:46 ` H. Peter Anvin
2013-06-04 15:54 ` Martin K. Petersen
2013-06-05 10:02 ` Bernd Schubert
2013-06-05 11:38 ` Bernd Schubert
2013-06-05 12:53 ` [PATCH] scsi: Check if the device support WRITE_SAME_10 Bernd Schubert
2013-06-05 19:14 ` Martin K. Petersen
2013-06-05 20:09 ` Bernd Schubert
2013-06-07 2:15 ` Martin K. Petersen
2013-06-12 19:34 ` Bernd Schubert
2013-06-05 19:11 ` RAID-10 keeps aborting Martin K. Petersen
2013-06-04 17:36 ` Dan Williams
2013-06-04 17:54 ` Martin K. Petersen
2013-06-04 17:57 ` H. Peter Anvin
2013-06-04 18:04 ` Martin K. Petersen
2013-06-04 18:32 ` Dan Williams
2013-06-04 18:38 ` H. Peter Anvin
2013-06-04 18:56 ` Dan Williams
2013-06-05 2:39 ` H. Peter Anvin
[not found] ` <(H.>
[not found] ` <Peter>
[not found] ` <Anvin's>
[not found] ` <message>
[not found] ` <of>
[not found] ` <"Wed>
[not found] ` <"Thu>
[not found] ` <"Tue>
[not found] ` <04>
[not found] ` <Jun>
[not found] ` <2013>
[not found] ` <19:39:58>
[not found] ` <-0700")>
2013-06-05 19:29 ` Martin K. Petersen
2013-06-06 18:27 ` Joe Lawrence
[not found] ` <(Joe>
2013-06-06 18:36 ` H. Peter Anvin
2013-06-12 14:43 ` Martin K. Petersen
[not found] ` <14:27:47>
[not found] ` <-0400")>
2013-06-07 2:19 ` Martin K. Petersen
2013-06-10 14:15 ` Joe Lawrence
2013-06-12 3:15 ` NeilBrown
2013-06-12 4:07 ` H. Peter Anvin
2013-06-12 6:29 ` Bernd Schubert
2013-06-12 10:22 ` Joe Lawrence
2013-06-12 14:28 ` Martin K. Petersen
2013-06-12 14:25 ` Martin K. Petersen
2013-06-12 14:29 ` H. Peter Anvin
2013-06-12 14:34 ` Martin K. Petersen
2013-06-12 14:37 ` H. Peter Anvin
2013-06-12 14:45 ` H. Peter Anvin
[not found] ` <5AA430FFE4486C448003201AC83BC85E0360CE3F@EXHQ.corp.stratus! .com>
[not found] ` <5AA430FFE4486C448003201AC83BC85E0360CE3F@EXHQ.corp.stratus.com>
2013-06-12 15:58 ` H. Peter Anvin
2013-06-13 3:10 ` NeilBrown
2013-06-13 3:13 ` H. Peter Anvin
2013-06-13 3:31 ` NeilBrown
2013-06-13 21:40 ` Martin K. Petersen
2013-06-13 2:45 ` Joe Lawrence
2013-06-13 3:11 ` NeilBrown [this message]
2013-06-11 21:50 ` Joe Lawrence
2013-06-11 21:53 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613131159.07250e04@notabene.brown \
--to=neilb@suse.de \
--cc=dan.j.williams@gmail.com \
--cc=hpa@zytor.com \
--cc=joe.lawrence@stratus.com \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).