linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Jonathan Brassow <jbrassow@redhat.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: Scrubbing "check" not working for RAID10 in 3.10-rc1+
Date: Tue, 25 Jun 2013 16:32:21 +1000	[thread overview]
Message-ID: <20130625163221.6f25f83d@notabene.brown> (raw)
In-Reply-To: <1372141160.2016.0.camel@f16>

[-- Attachment #1: Type: text/plain, Size: 1330 bytes --]

On Tue, 25 Jun 2013 01:19:20 -0500 Jonathan Brassow <jbrassow@redhat.com>
wrote:

> Neil,
> 
> I've noticed that the "check" operation no longer works for RAID10.  It
> works just fine for the other RAIDs.  The ("data-check") sync_thread
> kicks off just fine, sync_request_write() is called, but it never gets
> past:
>         if (i == conf->copies)
>                 goto done;
> The test I am performing creates a RAID array, waits for it to sync,
> shuts it down, writes random data to one of the devices, assembles the
> array, and then runs a "check" - there should be descrepancies.  The
> descrepancies are found and recorded in resync_mismatches for all RAIDs
> <= 3.9 and only for non-RAID10 3.10-rc1+.

I just tried on 3.10-rc5+ and it works as expected.
If you can provide a test script that fails, I'll look into it.

> 
> I'm sorry I haven't tracked it down yet and I'm going to be on vacation
> starting tomorrow with only intermittent access to e-mail.  Sorry to
> leave you hanging.

Go enjoy your vacation and don't worry about me hanging :-)

> 
> Thanks,
>  brassow
> 
> P.S.  This also reminded me of a patch I have concerning tracking the
> last sync action for the purpose of making mismatch_count more useful.
> I'll post that before leaving.
> 

Thanks.

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2013-06-25  6:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25  6:19 Scrubbing "check" not working for RAID10 in 3.10-rc1+ Jonathan Brassow
2013-06-25  6:32 ` NeilBrown [this message]
2013-07-15 15:35   ` Brassow Jonathan
2013-07-16  7:01     ` NeilBrown
2013-07-17 18:24       ` Brassow Jonathan
2013-07-15 15:40 ` Jonathan Brassow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130625163221.6f25f83d@notabene.brown \
    --to=neilb@suse.de \
    --cc=jbrassow@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).