linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Lukasz Dorau <lukasz.dorau@intel.com>
Cc: linux-raid@vger.kernel.org, pawel.baldysiak@intel.com
Subject: Re: [PATCH] mdmon: let mdmon know the layout
Date: Mon, 5 Aug 2013 15:12:37 +1000	[thread overview]
Message-ID: <20130805151237.72e8947d@notabene.brown> (raw)
In-Reply-To: <20130802081445.7222.5151.stgit@gklab-154-244.igk.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On Fri, 02 Aug 2013 10:14:45 +0200 Lukasz Dorau <lukasz.dorau@intel.com>
wrote:

> The following commit:
> 
> 	Fix is_resync_complete for RAID10
> 	commit 71d68ff62f945254240575cd836f5f2a09ced5d2
> 
> requires that mdmon knows the layout.
> So make manage_new() read the layout form sysfs.
> 
> Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
> ---
>  managemon.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/managemon.c b/managemon.c
> index 6cd93e5..7033c19 100644
> --- a/managemon.c
> +++ b/managemon.c
> @@ -650,8 +650,8 @@ static void manage_new(struct mdstat_ent *mdstat,
>  		return;
>  
>  	mdi = sysfs_read(-1, mdstat->devnm,
> -			 GET_LEVEL|GET_CHUNK|GET_DISKS|GET_COMPONENT|
> -			 GET_DEGRADED|GET_SAFEMODE|
> +			 GET_LEVEL|GET_LAYOUT|GET_CHUNK|GET_DISKS|
> +			 GET_COMPONENT|GET_DEGRADED|GET_SAFEMODE|
>  			 GET_DEVS|GET_OFFSET|GET_SIZE|GET_STATE);
>  
>  	if (!mdi)

Thanks.  I applied a very similar patch from Martin Wilck instead (his came
first:-)

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2013-08-05  5:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-02  8:14 [PATCH] mdmon: let mdmon know the layout Lukasz Dorau
2013-08-05  5:12 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130805151237.72e8947d@notabene.brown \
    --to=neilb@suse.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=lukasz.dorau@intel.com \
    --cc=pawel.baldysiak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).