linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Fix apparent cut-and-paste error in super_90_validate
@ 2013-08-20  2:26 Dave Jones
  2013-08-20  2:46 ` NeilBrown
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2013-08-20  2:26 UTC (permalink / raw)
  To: neilb; +Cc: linux-raid, Linux Kernel

Setting a variable to itself probably wasn't the intention here.

Signed-off-by: Dave Jones <davej@fedoraproject.org>

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 9f13e13..b9cb9e4 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -1180,7 +1180,7 @@ static int super_90_validate(struct mddev *mddev, struct md_rdev *rdev)
 			mddev->bitmap_info.offset =
 				mddev->bitmap_info.default_offset;
 			mddev->bitmap_info.space =
-				mddev->bitmap_info.space;
+				mddev->bitmap_info.default_space;
 		}
 
 	} else if (mddev->pers == NULL) {

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Fix apparent cut-and-paste error in super_90_validate
  2013-08-20  2:26 Fix apparent cut-and-paste error in super_90_validate Dave Jones
@ 2013-08-20  2:46 ` NeilBrown
  0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2013-08-20  2:46 UTC (permalink / raw)
  To: Dave Jones; +Cc: linux-raid, Linux Kernel

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

On Mon, 19 Aug 2013 22:26:32 -0400 Dave Jones <davej@redhat.com> wrote:

> Setting a variable to itself probably wasn't the intention here.

Probably not, no.

Applied, thanks.

NeilBrown


> 
> Signed-off-by: Dave Jones <davej@fedoraproject.org>
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 9f13e13..b9cb9e4 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -1180,7 +1180,7 @@ static int super_90_validate(struct mddev *mddev, struct md_rdev *rdev)
>  			mddev->bitmap_info.offset =
>  				mddev->bitmap_info.default_offset;
>  			mddev->bitmap_info.space =
> -				mddev->bitmap_info.space;
> +				mddev->bitmap_info.default_space;
>  		}
>  
>  	} else if (mddev->pers == NULL) {


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-20  2:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-20  2:26 Fix apparent cut-and-paste error in super_90_validate Dave Jones
2013-08-20  2:46 ` NeilBrown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).