linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shaohua Li <shli@kernel.org>
To: linux-raid@vger.kernel.org
Cc: neilb@suse.de, tj@kernel.org, dan.j.williams@gmail.com
Subject: [patch v3 2/5] raid5: fix stripe release order
Date: Tue, 27 Aug 2013 17:50:40 +0800	[thread overview]
Message-ID: <20130827095438.580030408@kernel.org> (raw)
In-Reply-To: 20130827095038.303090029@kernel.org

[-- Attachment #1: raid5-release_stripe-order.patch --]
[-- Type: text/plain, Size: 2255 bytes --]

patch "make release_stripe lockless" changes the order stripes are released.
Originally I thought block layer can take care of request merge, but it appears
there are still some requests not merged. It's easy to fix the order.

Signed-off-by: Shaohua Li <shli@fusionio.com>
---
 drivers/md/raid5.c    |    1 +
 include/linux/llist.h |    1 +
 lib/llist.c           |   27 +++++++++++++++++++++++++++
 3 files changed, 29 insertions(+)

Index: linux/include/linux/llist.h
===================================================================
--- linux.orig/include/linux/llist.h	2013-07-24 09:09:41.014384439 +0800
+++ linux/include/linux/llist.h	2013-07-25 15:09:03.109026773 +0800
@@ -172,4 +172,5 @@ static inline struct llist_node *llist_d
 
 extern struct llist_node *llist_del_first(struct llist_head *head);
 
+extern struct llist_node *llist_reverse_order(struct llist_node *head);
 #endif /* LLIST_H */
Index: linux/lib/llist.c
===================================================================
--- linux.orig/lib/llist.c	2013-07-24 09:09:41.062383834 +0800
+++ linux/lib/llist.c	2013-07-25 16:08:40.096054565 +0800
@@ -81,3 +81,30 @@ struct llist_node *llist_del_first(struc
 	return entry;
 }
 EXPORT_SYMBOL_GPL(llist_del_first);
+
+/*
+ * llist_reverse_order - reverse llist order
+ * @head: list head
+ *
+ * Return reversed list head
+ */
+struct llist_node *llist_reverse_order(struct llist_node *head)
+{
+	struct llist_node *second, *third;
+
+	if (head == NULL || head->next == NULL)
+		return head;
+	second = head->next;
+	head->next = NULL;
+
+	do {
+		third = second->next;
+		second->next = head;
+
+		head = second;
+		second = third;
+	} while (second);
+
+	return head;
+}
+EXPORT_SYMBOL_GPL(llist_reverse_order);
Index: linux/drivers/md/raid5.c
===================================================================
--- linux.orig/drivers/md/raid5.c	2013-07-25 15:02:38.289865404 +0800
+++ linux/drivers/md/raid5.c	2013-07-25 15:35:33.201040089 +0800
@@ -247,6 +247,7 @@ static int release_stripe_list(struct r5
 	struct llist_node *head;
 
 	head = llist_del_all(&conf->released_stripes);
+	head = llist_reverse_order(head);
 	while (head) {
 		sh = llist_entry(head, struct stripe_head, release_list);
 		head = llist_next(head);


  parent reply	other threads:[~2013-08-27  9:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27  9:50 [patch v3 0/5] raid5: make stripe handling multi-threading Shaohua Li
2013-08-27  9:50 ` [patch v3 1/5] raid5: make release_stripe lockless Shaohua Li
2013-08-28 14:04   ` Tejun Heo
2013-08-28 14:29     ` Shaohua Li
2013-08-28 14:30       ` Tejun Heo
2013-08-27  9:50 ` Shaohua Li [this message]
2013-08-28  3:41   ` [patch v3 2/5] raid5: fix stripe release order NeilBrown
2013-08-28  6:29     ` Shaohua Li
2013-08-28  6:37       ` NeilBrown
2013-08-27  9:50 ` [patch v3 3/5] raid5: offload stripe handle to workqueue Shaohua Li
2013-08-28  3:53   ` NeilBrown
2013-08-28  6:30     ` Shaohua Li
2013-08-28  6:56       ` NeilBrown
2013-08-27  9:50 ` [patch v3 4/5] raid5: sysfs entry to control worker thread number Shaohua Li
2013-08-27  9:50 ` [patch v3 5/5] raid5: only wakeup necessary threads Shaohua Li
2013-08-28  4:13   ` NeilBrown
2013-08-28  6:31     ` Shaohua Li
2013-08-28  6:59       ` NeilBrown
2013-08-29  7:40     ` Shaohua Li
2013-09-02  0:45       ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130827095438.580030408@kernel.org \
    --to=shli@kernel.org \
    --cc=dan.j.williams@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).