From: NeilBrown <neilb@suse.de>
To: ycbzzjlby@gmail.com
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
Bian Yu <bianyu@kedacom.com>
Subject: Re: [PATCH] raid5: Retry R5_ReadNoMerge flag when hit a read error.
Date: Wed, 11 Sep 2013 12:42:00 +1000 [thread overview]
Message-ID: <20130911124200.6855813b@notabene.brown> (raw)
In-Reply-To: <1378080782-9971-1-git-send-email-ycbzzjlby@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]
On Sun, 1 Sep 2013 20:13:02 -0400 ycbzzjlby@gmail.com wrote:
> From: Bian Yu <bianyu@kedacom.com>
>
> Because of block layer merge, one bio fails will cause other bios
> which belongs to the same request fails, so raid5_end_read_request
> will record all these bios as badblocks.
> If retry request with R5_ReadNoMerge flag to avoid bios merge,
> badblocks can only record sector which is bad exactly.
>
> test:
> hdparm --yes-i-know-what-i-am-doing --make-bad-sector 300000 /dev/sdb
> mdadm -C /dev/md0 -l5 -n3 /dev/sd[bcd] --assume-clean
> mdadm /dev/md0 -f /dev/sdd
> mdadm /dev/md0 -r /dev/sdd
> mdadm --zero-superblock /dev/sdd
> mdadm /dev/md0 -a /dev/sdd
>
> 1. Without this patch:
> cat /sys/block/md0/md/rd*/bad_blocks
> 299776 256
> 299776 256
>
> 2. With this patch:
> cat /sys/block/md0/md/rd*/bad_blocks
> 300000 8
> 300000 8
>
> Signed-off-by: Bian Yu <bianyu@kedacom.com>
> ---
> drivers/md/raid5.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index ff1aecf..ee8c280 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -1924,6 +1924,9 @@ static void raid5_end_read_request(struct bio * bi, int error)
> mdname(conf->mddev), bdn);
> else
> retry = 1;
> + if (set_bad && test_bit(In_sync, &rdev->flags)
> + && !test_bit(R5_ReadNoMerge, &sh->dev[i].flags))
> + retry = 1;
> if (retry)
> if (test_bit(R5_ReadNoMerge, &sh->dev[i].flags)) {
> set_bit(R5_ReadError, &sh->dev[i].flags);
Applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2013-09-11 2:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 0:13 [PATCH] raid5: Retry R5_ReadNoMerge flag when hit a read error ycbzzjlby
2013-09-11 2:42 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911124200.6855813b@notabene.brown \
--to=neilb@suse.de \
--cc=bianyu@kedacom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=ycbzzjlby@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).