* [PATCH] raid5: Retry R5_ReadNoMerge flag when hit a read error.
@ 2013-09-02 0:13 ycbzzjlby
2013-09-11 2:42 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: ycbzzjlby @ 2013-09-02 0:13 UTC (permalink / raw)
To: neilb; +Cc: linux-raid, linux-kernel, Bian Yu
From: Bian Yu <bianyu@kedacom.com>
Because of block layer merge, one bio fails will cause other bios
which belongs to the same request fails, so raid5_end_read_request
will record all these bios as badblocks.
If retry request with R5_ReadNoMerge flag to avoid bios merge,
badblocks can only record sector which is bad exactly.
test:
hdparm --yes-i-know-what-i-am-doing --make-bad-sector 300000 /dev/sdb
mdadm -C /dev/md0 -l5 -n3 /dev/sd[bcd] --assume-clean
mdadm /dev/md0 -f /dev/sdd
mdadm /dev/md0 -r /dev/sdd
mdadm --zero-superblock /dev/sdd
mdadm /dev/md0 -a /dev/sdd
1. Without this patch:
cat /sys/block/md0/md/rd*/bad_blocks
299776 256
299776 256
2. With this patch:
cat /sys/block/md0/md/rd*/bad_blocks
300000 8
300000 8
Signed-off-by: Bian Yu <bianyu@kedacom.com>
---
drivers/md/raid5.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index ff1aecf..ee8c280 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -1924,6 +1924,9 @@ static void raid5_end_read_request(struct bio * bi, int error)
mdname(conf->mddev), bdn);
else
retry = 1;
+ if (set_bad && test_bit(In_sync, &rdev->flags)
+ && !test_bit(R5_ReadNoMerge, &sh->dev[i].flags))
+ retry = 1;
if (retry)
if (test_bit(R5_ReadNoMerge, &sh->dev[i].flags)) {
set_bit(R5_ReadError, &sh->dev[i].flags);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] raid5: Retry R5_ReadNoMerge flag when hit a read error.
2013-09-02 0:13 [PATCH] raid5: Retry R5_ReadNoMerge flag when hit a read error ycbzzjlby
@ 2013-09-11 2:42 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2013-09-11 2:42 UTC (permalink / raw)
To: ycbzzjlby; +Cc: linux-raid, linux-kernel, Bian Yu
[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]
On Sun, 1 Sep 2013 20:13:02 -0400 ycbzzjlby@gmail.com wrote:
> From: Bian Yu <bianyu@kedacom.com>
>
> Because of block layer merge, one bio fails will cause other bios
> which belongs to the same request fails, so raid5_end_read_request
> will record all these bios as badblocks.
> If retry request with R5_ReadNoMerge flag to avoid bios merge,
> badblocks can only record sector which is bad exactly.
>
> test:
> hdparm --yes-i-know-what-i-am-doing --make-bad-sector 300000 /dev/sdb
> mdadm -C /dev/md0 -l5 -n3 /dev/sd[bcd] --assume-clean
> mdadm /dev/md0 -f /dev/sdd
> mdadm /dev/md0 -r /dev/sdd
> mdadm --zero-superblock /dev/sdd
> mdadm /dev/md0 -a /dev/sdd
>
> 1. Without this patch:
> cat /sys/block/md0/md/rd*/bad_blocks
> 299776 256
> 299776 256
>
> 2. With this patch:
> cat /sys/block/md0/md/rd*/bad_blocks
> 300000 8
> 300000 8
>
> Signed-off-by: Bian Yu <bianyu@kedacom.com>
> ---
> drivers/md/raid5.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index ff1aecf..ee8c280 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -1924,6 +1924,9 @@ static void raid5_end_read_request(struct bio * bi, int error)
> mdname(conf->mddev), bdn);
> else
> retry = 1;
> + if (set_bad && test_bit(In_sync, &rdev->flags)
> + && !test_bit(R5_ReadNoMerge, &sh->dev[i].flags))
> + retry = 1;
> if (retry)
> if (test_bit(R5_ReadNoMerge, &sh->dev[i].flags)) {
> set_bit(R5_ReadError, &sh->dev[i].flags);
Applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-11 2:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-02 0:13 [PATCH] raid5: Retry R5_ReadNoMerge flag when hit a read error ycbzzjlby
2013-09-11 2:42 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).