* [PATCH] mdmon: honour --offroot, again
@ 2013-09-11 20:15 mwilck
2013-09-12 5:42 ` NeilBrown
0 siblings, 1 reply; 4+ messages in thread
From: mwilck @ 2013-09-11 20:15 UTC (permalink / raw)
To: neilb, linux-raid; +Cc: mwilck
commit 3e32ba9d removed support for --offroot, and a9c15847 made
mdmon use @ in argv[0] only when started from initrd.
This breaks mdadm in OpenSUSE 12.3, which starts mdmon from the
root file system and relies on --offroot to work as documented earlier.
Reintroducing --offroot as an undocumented option, as its use is going to
go away soon anyway.
If this can't be applied, it should probably be included as distro-specific
patch if mdadm 3.3 is built for OpenSUSE 12.3. I haven't checked if the
patch is necesary for OpenSUSE Factory, too.
Signed-off-by: Martin Wilck <mwilck@arcor.de>
---
mdmon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mdmon.c b/mdmon.c
index f0b0623..8cd53d8 100644
--- a/mdmon.c
+++ b/mdmon.c
@@ -320,7 +320,7 @@ int main(int argc, char *argv[])
dofork = 0;
break;
case OffRootOpt:
- /* silently ignore old option */
+ argv[0][0] = '@';
break;
case 'h':
default:
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mdmon: honour --offroot, again
2013-09-11 20:15 [PATCH] mdmon: honour --offroot, again mwilck
@ 2013-09-12 5:42 ` NeilBrown
2013-09-12 18:25 ` Martin Wilck
0 siblings, 1 reply; 4+ messages in thread
From: NeilBrown @ 2013-09-12 5:42 UTC (permalink / raw)
To: mwilck; +Cc: linux-raid
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On Wed, 11 Sep 2013 22:15:19 +0200 mwilck@arcor.de wrote:
> commit 3e32ba9d removed support for --offroot, and a9c15847 made
> mdmon use @ in argv[0] only when started from initrd.
>
> This breaks mdadm in OpenSUSE 12.3, which starts mdmon from the
> root file system and relies on --offroot to work as documented earlier.
>
> Reintroducing --offroot as an undocumented option, as its use is going to
> go away soon anyway.
>
> If this can't be applied, it should probably be included as distro-specific
> patch if mdadm 3.3 is built for OpenSUSE 12.3. I haven't checked if the
> patch is necesary for OpenSUSE Factory, too.
>
> Signed-off-by: Martin Wilck <mwilck@arcor.de>
> ---
> mdmon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mdmon.c b/mdmon.c
> index f0b0623..8cd53d8 100644
> --- a/mdmon.c
> +++ b/mdmon.c
> @@ -320,7 +320,7 @@ int main(int argc, char *argv[])
> dofork = 0;
> break;
> case OffRootOpt:
> - /* silently ignore old option */
> + argv[0][0] = '@';
> break;
> case 'h':
> default:
Aggh... This is all pretty horrible isn't it?
I've applied your patch because I don't think it can break anything and it
could possible help as you say.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mdmon: honour --offroot, again
2013-09-12 5:42 ` NeilBrown
@ 2013-09-12 18:25 ` Martin Wilck
2013-09-12 22:42 ` NeilBrown
0 siblings, 1 reply; 4+ messages in thread
From: Martin Wilck @ 2013-09-12 18:25 UTC (permalink / raw)
To: NeilBrown; +Cc: linux-raid
On 09/12/2013 07:42 AM, NeilBrown wrote:
> On Wed, 11 Sep 2013 22:15:19 +0200 mwilck@arcor.de wrote:
>
>> Reintroducing --offroot as an undocumented option, as its use is going to
>> go away soon anyway.
>>
>
> Aggh... This is all pretty horrible isn't it?
>
> I've applied your patch because I don't think it can break anything and it
> could possible help as you say.
I just verified that OpenSUSE Factory still needs this patch as well.
Fedora is probably the only distribution that "properly" (according to
the systemd developers) starts and stops mdmon from "offroot" (i.e. initrd).
Martin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-12 22:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 20:15 [PATCH] mdmon: honour --offroot, again mwilck
2013-09-12 5:42 ` NeilBrown
2013-09-12 18:25 ` Martin Wilck
2013-09-12 22:42 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).