From: NeilBrown <neilb@suse.de>
To: mwilck@arcor.de
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 2/2] DDF: brief_examine_subarrays_ddf: print array name
Date: Thu, 12 Sep 2013 15:44:41 +1000 [thread overview]
Message-ID: <20130912154441.0658f011@notabene.brown> (raw)
In-Reply-To: <1378929335-12606-2-git-send-email-mwilck@arcor.de>
[-- Attachment #1: Type: text/plain, Size: 1734 bytes --]
On Wed, 11 Sep 2013 21:55:35 +0200 mwilck@arcor.de wrote:
> Print an array name in brief output, like IMSM does.
>
> SUSE's YaST2 (libstorage) needs this in order to detect MD arrays
> during installation.
>
> Signed-off-by: Martin Wilck <mwilck@arcor.de>
> ---
> super-ddf.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/super-ddf.c b/super-ddf.c
> index c2ac88b..00a5c8b 100644
> --- a/super-ddf.c
> +++ b/super-ddf.c
> @@ -1518,6 +1518,7 @@ static void getinfo_super_ddf(struct supertype *st, struct mdinfo *info, char *m
>
> static void uuid_from_ddf_guid(const char *guid, int uuid[4]);
> static void uuid_from_super_ddf(struct supertype *st, int uuid[4]);
> +static void _ddf_array_name(char *name, const struct ddf_super *ddf, int i);
>
> static unsigned int get_vd_num_of_subarray(struct supertype *st)
> {
> @@ -1577,6 +1578,7 @@ static void brief_examine_subarrays_ddf(struct supertype *st, int verbose)
> struct virtual_entry *ve = &ddf->virt->entries[i];
> struct vcl vcl;
> char nbuf1[64];
> + char namebuf[17];
> if (all_ff(ve->guid))
> continue;
> memcpy(vcl.conf.guid, ve->guid, DDF_GUID_LEN);
> @@ -1584,7 +1586,9 @@ static void brief_examine_subarrays_ddf(struct supertype *st, int verbose)
> vcl.vcnum = i;
> uuid_from_super_ddf(st, info.uuid);
> fname_from_uuid(st, &info, nbuf1, ':');
> - printf("ARRAY container=%s member=%d UUID=%s\n",
> + _ddf_array_name(namebuf, ddf, i);
> + printf("ARRAY%s%s container=%s member=%d UUID=%s\n",
> + namebuf[0] == '\0' ? "" : " /dev/md/", namebuf,
> nbuf+5, i, nbuf1+5);
> }
> }
This an previous applied - thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2013-09-12 5:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 21:26 [PATCH 1/2] DDF: brief_examine_subarrays_ddf: print array name mwilck
2013-09-06 21:26 ` [PATCH 2/2] DDF: new algorithm for subarray UUID mwilck
2013-09-07 19:23 ` Martin Wilck
2013-09-09 1:20 ` NeilBrown
2013-09-09 18:37 ` Martin Wilck
2013-09-09 23:51 ` NeilBrown
2013-09-09 1:15 ` [PATCH 1/2] DDF: brief_examine_subarrays_ddf: print array name NeilBrown
2013-09-09 18:31 ` Martin Wilck
2013-09-09 18:40 ` [PATCH 2/2] DDF: handle fake RAIDs with changing subarray UUIDs mwilck
2013-09-09 23:48 ` NeilBrown
2013-09-10 0:01 ` [PATCH 1/2] DDF: brief_examine_subarrays_ddf: print array name NeilBrown
2013-09-11 19:50 ` Martin Wilck
2013-09-11 19:55 ` Martin Wilck
2013-09-12 5:47 ` NeilBrown
2013-09-11 19:55 ` [PATCH 1/2] DDF: factor out array name generation mwilck
2013-09-11 19:55 ` [PATCH 2/2] DDF: brief_examine_subarrays_ddf: print array name mwilck
2013-09-12 5:44 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912154441.0658f011@notabene.brown \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=mwilck@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).