[PATCH] mdmon: honour --offroot, again

[PATCH] mdmon: honour --offroot, again

[mwilck]

commit 3e32ba9d removed support for --offroot, and a9c15847 made
mdmon use @ in argv[0] only when started from initrd.

This breaks mdadm in OpenSUSE 12.3, which starts mdmon from the
root file system and relies on --offroot to work as documented earlier.

Reintroducing --offroot as an undocumented option, as its use is going to
go away soon anyway.

If this can't be applied, it should probably be included as distro-specific
patch if mdadm 3.3 is built for OpenSUSE 12.3. I haven't checked if the
patch is necesary for OpenSUSE Factory, too.

Signed-off-by: Martin Wilck <mwilck@arcor.de>
---
 mdmon.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mdmon.c b/mdmon.c
index f0b0623..8cd53d8 100644
--- a/mdmon.c
+++ b/mdmon.c
@@ -320,7 +320,7 @@ int main(int argc, char *argv[])
 			dofork = 0;
 			break;
 		case OffRootOpt:
-			/* silently ignore old option */
+			argv[0][0] = '@';
 			break;
 		case 'h':
 		default:
-- 
1.7.3.4

Re: [PATCH] mdmon: honour --offroot, again

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

On Wed, 11 Sep 2013 22:15:19 +0200 mwilck@arcor.de wrote:

> commit 3e32ba9d removed support for --offroot, and a9c15847 made
> mdmon use @ in argv[0] only when started from initrd.
> 
> This breaks mdadm in OpenSUSE 12.3, which starts mdmon from the
> root file system and relies on --offroot to work as documented earlier.
> 
> Reintroducing --offroot as an undocumented option, as its use is going to
> go away soon anyway.
> 
> If this can't be applied, it should probably be included as distro-specific
> patch if mdadm 3.3 is built for OpenSUSE 12.3. I haven't checked if the
> patch is necesary for OpenSUSE Factory, too.
> 
> Signed-off-by: Martin Wilck <mwilck@arcor.de>
> ---
>  mdmon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mdmon.c b/mdmon.c
> index f0b0623..8cd53d8 100644
> --- a/mdmon.c
> +++ b/mdmon.c
> @@ -320,7 +320,7 @@ int main(int argc, char *argv[])
>  			dofork = 0;
>  			break;
>  		case OffRootOpt:
> -			/* silently ignore old option */
> +			argv[0][0] = '@';
>  			break;
>  		case 'h':
>  		default:

Aggh...  This is all pretty horrible isn't it?

I've applied your patch because I don't think it can break anything and it
could possible help as you say.

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [PATCH] mdmon: honour --offroot, again

[Martin Wilck]

On 09/12/2013 07:42 AM, NeilBrown wrote:
> On Wed, 11 Sep 2013 22:15:19 +0200 mwilck@arcor.de wrote:
> 
>> Reintroducing --offroot as an undocumented option, as its use is going to
>> go away soon anyway.
>>
> 
> Aggh...  This is all pretty horrible isn't it?
> 
> I've applied your patch because I don't think it can break anything and it
> could possible help as you say.

I just verified that OpenSUSE Factory still needs this patch as well.
Fedora is probably the only distribution that "properly" (according to
the systemd developers) starts and stops mdmon from "offroot" (i.e. initrd).

Martin

Re: [PATCH] mdmon: honour --offroot, again

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

On Thu, 12 Sep 2013 20:25:46 +0200 Martin Wilck <mwilck@arcor.de> wrote:

> On 09/12/2013 07:42 AM, NeilBrown wrote:
> > On Wed, 11 Sep 2013 22:15:19 +0200 mwilck@arcor.de wrote:
> > 
> >> Reintroducing --offroot as an undocumented option, as its use is going to
> >> go away soon anyway.
> >>
> > 
> > Aggh...  This is all pretty horrible isn't it?
> > 
> > I've applied your patch because I don't think it can break anything and it
> > could possible help as you say.
> 
> I just verified that OpenSUSE Factory still needs this patch as well.
> Fedora is probably the only distribution that "properly" (according to
> the systemd developers) starts and stops mdmon from "offroot" (i.e. initrd).
> 

Thanks ... I'd better include it in my update for openSUSE 13.1-rc1 then ;-)

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]