From: NeilBrown <neilb@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: linux-raid@vger.kernel.org
Subject: Re: Remove bashism from Makefile
Date: Wed, 18 Sep 2013 09:22:07 +1000 [thread overview]
Message-ID: <20130918092207.4f3784dc@notabene.brown> (raw)
In-Reply-To: <1379434840-9971-1-git-send-email-mjt@msgid.tls.msk.ru>
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
On Tue, 17 Sep 2013 20:20:40 +0400 Michael Tokarev <mjt@tls.msk.ru> wrote:
> Makefile uses [ x == y ] construct which does not work
> with POSIX shell. Since this is just testing a flag,
> replace it with string comparison (=) operator instead.
>
> Signed-off-By: Michael Tokarev <mjt@tls.msk.ru>
>
> diff --git a/Makefile b/Makefile
> index e8da3a5..c60cc2c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -156,7 +156,7 @@ all : check_rundir mdadm mdmon
> man : mdadm.man md.man mdadm.conf.man mdmon.man raid6check.man
>
> check_rundir:
> - @if [ ! -d "$(dir $(RUN_DIR))" -a "$(CHECK_RUN_DIR)" == 1 ]; then \
> + @if [ ! -d "$(dir $(RUN_DIR))" -a "$(CHECK_RUN_DIR)" = 1 ]; then \
> echo "***** Parent of $(RUN_DIR) does not exist. Maybe set different RUN_DIR="; \
> echo "***** e.g. make RUN_DIR=/dev/.mdadm" ; \
> echo "***** or set CHECK_RUN_DIR=0"; exit 1; \
Applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2013-09-17 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 16:20 Remove bashism from Makefile Michael Tokarev
2013-09-17 23:22 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918092207.4f3784dc@notabene.brown \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=mjt@tls.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).