From: NeilBrown <neilb@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Shaohua Li <shli@kernel.org>,
linux-raid@vger.kernel.org, Jes.Sorensen@redhat.com
Subject: Re: [patch 1/2]raid5: set bio bi_vcnt 0 for discard request
Date: Thu, 24 Oct 2013 12:58:50 +1100 [thread overview]
Message-ID: <20131024125850.76eff7da@notabene.brown> (raw)
In-Reply-To: <yq14n88h0lk.fsf@sermon.lab.mkp.net>
[-- Attachment #1: Type: text/plain, Size: 627 bytes --]
On Wed, 23 Oct 2013 04:07:19 -0400 "Martin K. Petersen"
<martin.petersen@oracle.com> wrote:
> >>>>> "Shaohua" == Shaohua Li <shli@kernel.org> writes:
>
> Shaohua> SCSI layer will add new payload for discard request. If two
> Shaohua> bios are merged to one, the second bio has bi_vcnt 1 which is
> Shaohua> set in raid5. This will confuse SCSI and cause oops.
>
> A discard bio does not have a payload prior to the SCSI command being
> prepared so vcnt should indeed be 0.
>
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
>
Thanks Martin. I'll be sending this to Linus shortly.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2013-10-24 1:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 6:50 [patch 1/2]raid5: set bio bi_vcnt 0 for discard request Shaohua Li
2013-10-23 8:07 ` Martin K. Petersen
2013-10-24 1:58 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024125850.76eff7da@notabene.brown \
--to=neilb@suse.de \
--cc=Jes.Sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).