* [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md_p.h
@ 2013-10-29 12:28 Aurelien Jarno
2013-10-30 6:12 ` NeilBrown
2013-10-30 6:20 ` NeilBrown
0 siblings, 2 replies; 3+ messages in thread
From: Aurelien Jarno @ 2013-10-29 12:28 UTC (permalink / raw)
To: Neil Brown, linux-raid, linux-kernel; +Cc: Aurelien Jarno
linux/raid/md_p.h is using conditionals depending on endianess and fails
with an error if neither of __BIG_ENDIAN, __LITTLE_ENDIAN or
__BYTE_ORDER are defined, but it doesn't include any header which can
define these constants. This make this header unusable alone.
This patch adds a #include <asm/byteorder.h> at the beginning of this
header to make it usable alone. This is needed to compile klibc on MIPS.
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
include/uapi/linux/raid/md_p.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/raid/md_p.h b/include/uapi/linux/raid/md_p.h
index fe1a540..f7cf7f3 100644
--- a/include/uapi/linux/raid/md_p.h
+++ b/include/uapi/linux/raid/md_p.h
@@ -16,6 +16,7 @@
#define _MD_P_H
#include <linux/types.h>
+#include <asm/byteorder.h>
/*
* RAID superblock.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md_p.h
2013-10-29 12:28 [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md_p.h Aurelien Jarno
@ 2013-10-30 6:12 ` NeilBrown
2013-10-30 6:20 ` NeilBrown
1 sibling, 0 replies; 3+ messages in thread
From: NeilBrown @ 2013-10-30 6:12 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: linux-raid, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
On Tue, 29 Oct 2013 13:28:58 +0100 Aurelien Jarno <aurelien@aurel32.net>
wrote:
> linux/raid/md_p.h is using conditionals depending on endianess and fails
> with an error if neither of __BIG_ENDIAN, __LITTLE_ENDIAN or
> __BYTE_ORDER are defined, but it doesn't include any header which can
> define these constants. This make this header unusable alone.
>
> This patch adds a #include <asm/byteorder.h> at the beginning of this
> header to make it usable alone. This is needed to compile klibc on MIPS.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> include/uapi/linux/raid/md_p.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/raid/md_p.h b/include/uapi/linux/raid/md_p.h
> index fe1a540..f7cf7f3 100644
> --- a/include/uapi/linux/raid/md_p.h
> +++ b/include/uapi/linux/raid/md_p.h
> @@ -16,6 +16,7 @@
> #define _MD_P_H
>
> #include <linux/types.h>
> +#include <asm/byteorder.h>
>
> /*
> * RAID superblock.
Makes sense. Applied. Thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md_p.h
2013-10-29 12:28 [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md_p.h Aurelien Jarno
2013-10-30 6:12 ` NeilBrown
@ 2013-10-30 6:20 ` NeilBrown
1 sibling, 0 replies; 3+ messages in thread
From: NeilBrown @ 2013-10-30 6:20 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: linux-raid, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
On Tue, 29 Oct 2013 13:28:58 +0100 Aurelien Jarno <aurelien@aurel32.net>
wrote:
> linux/raid/md_p.h is using conditionals depending on endianess and fails
> with an error if neither of __BIG_ENDIAN, __LITTLE_ENDIAN or
> __BYTE_ORDER are defined, but it doesn't include any header which can
> define these constants. This make this header unusable alone.
>
> This patch adds a #include <asm/byteorder.h> at the beginning of this
> header to make it usable alone. This is needed to compile klibc on MIPS.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> include/uapi/linux/raid/md_p.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/raid/md_p.h b/include/uapi/linux/raid/md_p.h
> index fe1a540..f7cf7f3 100644
> --- a/include/uapi/linux/raid/md_p.h
> +++ b/include/uapi/linux/raid/md_p.h
> @@ -16,6 +16,7 @@
> #define _MD_P_H
>
> #include <linux/types.h>
> +#include <asm/byteorder.h>
>
> /*
> * RAID superblock.
Makes sense. Applied. Thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-30 6:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-29 12:28 [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md_p.h Aurelien Jarno
2013-10-30 6:12 ` NeilBrown
2013-10-30 6:20 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).