From: NeilBrown <neilb@suse.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md_p.h
Date: Wed, 30 Oct 2013 17:20:13 +1100 [thread overview]
Message-ID: <20131030172013.5dae6baa@notabene.brown> (raw)
In-Reply-To: <1383049738-26107-1-git-send-email-aurelien@aurel32.net>
[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]
On Tue, 29 Oct 2013 13:28:58 +0100 Aurelien Jarno <aurelien@aurel32.net>
wrote:
> linux/raid/md_p.h is using conditionals depending on endianess and fails
> with an error if neither of __BIG_ENDIAN, __LITTLE_ENDIAN or
> __BYTE_ORDER are defined, but it doesn't include any header which can
> define these constants. This make this header unusable alone.
>
> This patch adds a #include <asm/byteorder.h> at the beginning of this
> header to make it usable alone. This is needed to compile klibc on MIPS.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> include/uapi/linux/raid/md_p.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/raid/md_p.h b/include/uapi/linux/raid/md_p.h
> index fe1a540..f7cf7f3 100644
> --- a/include/uapi/linux/raid/md_p.h
> +++ b/include/uapi/linux/raid/md_p.h
> @@ -16,6 +16,7 @@
> #define _MD_P_H
>
> #include <linux/types.h>
> +#include <asm/byteorder.h>
>
> /*
> * RAID superblock.
Makes sense. Applied. Thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2013-10-30 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 12:28 [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md_p.h Aurelien Jarno
2013-10-30 6:12 ` NeilBrown
2013-10-30 6:20 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030172013.5dae6baa@notabene.brown \
--to=neilb@suse.de \
--cc=aurelien@aurel32.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).