From: axboe <axboe@kernel.dk>
To: NeilBrown <neilb@suse.de>
Cc: majianpeng <majianpeng@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE.
Date: Thu, 31 Oct 2013 08:10:16 -0600 [thread overview]
Message-ID: <20131031141016.GE10091@kernel.dk> (raw)
In-Reply-To: <20131031141056.1525429a@notabene.brown>
On Thu, Oct 31 2013, NeilBrown wrote:
> On Wed, 30 Oct 2013 10:41:46 +0800 majianpeng <majianpeng@gmail.com> wrote:
>
> > For R5_ReadNoMerge,it mean this bio can't merge with other bios or
> > request.It used REQ_FLUSH to achieve this. But REQ_NOMERGE can do the
> > same work.
> >
> > Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> > ---
> > drivers/md/raid5.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> > index f8b9068..8e0aeaa 100644
> > --- a/drivers/md/raid5.c
> > +++ b/drivers/md/raid5.c
> > @@ -772,7 +772,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
> > bi->bi_sector = (sh->sector
> > + rdev->data_offset);
> > if (test_bit(R5_ReadNoMerge, &sh->dev[i].flags))
> > - bi->bi_rw |= REQ_FLUSH;
> > + bi->bi_rw |= REQ_NOMERGE;
> >
> > bi->bi_vcnt = 1;
> > bi->bi_io_vec[0].bv_len = STRIPE_SIZE;
>
> Thanks.
>
> I've queued this up pending Jens' acceptance of the other patches.
I've queued up the other two for 3.13.
--
Jens Axboe
prev parent reply other threads:[~2013-10-31 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 2:41 [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE majianpeng
2013-10-31 3:10 ` NeilBrown
2013-10-31 5:24 ` kedacomkernel
2013-10-31 14:10 ` axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031141016.GE10091@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=majianpeng@gmail.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).