* [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE.
@ 2013-10-30 2:41 majianpeng
2013-10-31 3:10 ` NeilBrown
0 siblings, 1 reply; 4+ messages in thread
From: majianpeng @ 2013-10-30 2:41 UTC (permalink / raw)
To: axboe, NeilBrown; +Cc: LKML, linux-raid
For R5_ReadNoMerge,it mean this bio can't merge with other bios or
request.It used REQ_FLUSH to achieve this. But REQ_NOMERGE can do the
same work.
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
drivers/md/raid5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index f8b9068..8e0aeaa 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -772,7 +772,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
bi->bi_sector = (sh->sector
+ rdev->data_offset);
if (test_bit(R5_ReadNoMerge, &sh->dev[i].flags))
- bi->bi_rw |= REQ_FLUSH;
+ bi->bi_rw |= REQ_NOMERGE;
bi->bi_vcnt = 1;
bi->bi_io_vec[0].bv_len = STRIPE_SIZE;
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE.
2013-10-30 2:41 [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE majianpeng
@ 2013-10-31 3:10 ` NeilBrown
2013-10-31 5:24 ` kedacomkernel
2013-10-31 14:10 ` axboe
0 siblings, 2 replies; 4+ messages in thread
From: NeilBrown @ 2013-10-31 3:10 UTC (permalink / raw)
To: majianpeng; +Cc: axboe, LKML, linux-raid
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
On Wed, 30 Oct 2013 10:41:46 +0800 majianpeng <majianpeng@gmail.com> wrote:
> For R5_ReadNoMerge,it mean this bio can't merge with other bios or
> request.It used REQ_FLUSH to achieve this. But REQ_NOMERGE can do the
> same work.
>
> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> ---
> drivers/md/raid5.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index f8b9068..8e0aeaa 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -772,7 +772,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
> bi->bi_sector = (sh->sector
> + rdev->data_offset);
> if (test_bit(R5_ReadNoMerge, &sh->dev[i].flags))
> - bi->bi_rw |= REQ_FLUSH;
> + bi->bi_rw |= REQ_NOMERGE;
>
> bi->bi_vcnt = 1;
> bi->bi_io_vec[0].bv_len = STRIPE_SIZE;
Thanks.
I've queued this up pending Jens' acceptance of the other patches.
By the way, your patch file has a carriage return as well as a newline at the
end of each line.
"patch" can still handle them but "git am" doesn't like it.
If you are able to send the patches as plain text with just a NEWLINE at the
end of each line, rather than base64 encodes with carriage returns, it would
help a little.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Re: [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE.
2013-10-31 3:10 ` NeilBrown
@ 2013-10-31 5:24 ` kedacomkernel
2013-10-31 14:10 ` axboe
1 sibling, 0 replies; 4+ messages in thread
From: kedacomkernel @ 2013-10-31 5:24 UTC (permalink / raw)
To: NeilBrown, majianpeng; +Cc: axboe, LKML, linux-raid
>On Wed, 30 Oct 2013 10:41:46 +0800 majianpeng <majianpeng@gmail.com> wrote:
>
>> For R5_ReadNoMerge,it mean this bio can't merge with other bios or
>> request.It used REQ_FLUSH to achieve this. But REQ_NOMERGE can do the
>> same work.
>>
>> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
>> ---
>> drivers/md/raid5.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
>> index f8b9068..8e0aeaa 100644
>> --- a/drivers/md/raid5.c
>> +++ b/drivers/md/raid5.c
>> @@ -772,7 +772,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
>> bi->bi_sector = (sh->sector
>> + rdev->data_offset);
>> if (test_bit(R5_ReadNoMerge, &sh->dev[i].flags))
>> - bi->bi_rw |= REQ_FLUSH;
>> + bi->bi_rw |= REQ_NOMERGE;
>>
>> bi->bi_vcnt = 1;
>> bi->bi_io_vec[0].bv_len = STRIPE_SIZE;
>
>Thanks.
>
>I've queued this up pending Jens' acceptance of the other patches.
>
>By the way, your patch file has a carriage return as well as a newline at the
>end of each line.
>"patch" can still handle them but "git am" doesn't like it.
>
>If you are able to send the patches as plain text with just a NEWLINE at the
>end of each line, rather than base64 encodes with carriage returns, it would
>help a little.
>
Sorroy for that, i'll pay attention to this.
Thanks!
Jianpeng Ma
>Thanks,
>NeilBrown
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE.
2013-10-31 3:10 ` NeilBrown
2013-10-31 5:24 ` kedacomkernel
@ 2013-10-31 14:10 ` axboe
1 sibling, 0 replies; 4+ messages in thread
From: axboe @ 2013-10-31 14:10 UTC (permalink / raw)
To: NeilBrown; +Cc: majianpeng, LKML, linux-raid
On Thu, Oct 31 2013, NeilBrown wrote:
> On Wed, 30 Oct 2013 10:41:46 +0800 majianpeng <majianpeng@gmail.com> wrote:
>
> > For R5_ReadNoMerge,it mean this bio can't merge with other bios or
> > request.It used REQ_FLUSH to achieve this. But REQ_NOMERGE can do the
> > same work.
> >
> > Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> > ---
> > drivers/md/raid5.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> > index f8b9068..8e0aeaa 100644
> > --- a/drivers/md/raid5.c
> > +++ b/drivers/md/raid5.c
> > @@ -772,7 +772,7 @@ static void ops_run_io(struct stripe_head *sh, struct stripe_head_state *s)
> > bi->bi_sector = (sh->sector
> > + rdev->data_offset);
> > if (test_bit(R5_ReadNoMerge, &sh->dev[i].flags))
> > - bi->bi_rw |= REQ_FLUSH;
> > + bi->bi_rw |= REQ_NOMERGE;
> >
> > bi->bi_vcnt = 1;
> > bi->bi_io_vec[0].bv_len = STRIPE_SIZE;
>
> Thanks.
>
> I've queued this up pending Jens' acceptance of the other patches.
I've queued up the other two for 3.13.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-31 14:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-30 2:41 [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE majianpeng
2013-10-31 3:10 ` NeilBrown
2013-10-31 5:24 ` kedacomkernel
2013-10-31 14:10 ` axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).