From: Joe Thornber <thornber@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: agk@redhat.com, snitzer@redhat.com, neilb@suse.de,
linux-raid@vger.kernel.org, yongjun_wei@trendmicro.com.cn
Subject: Re: [dm-devel] [PATCH -next] dm cache policy mq:: use list_del_init instead of list_del/INIT_LIST_HEAD
Date: Fri, 15 Nov 2013 10:58:23 +0000 [thread overview]
Message-ID: <20131115105822.GA18770@debian> (raw)
In-Reply-To: <CAPgLHd_iO2aHnn-uBp=1OYafVonrSfXnEcW7Mz=vp3btkkygPA@mail.gmail.com>
ACK
On Fri, Nov 15, 2013 at 05:47:12PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_del_init() instead of list_del() + INIT_LIST_HEAD().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/md/dm-cache-policy-mq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/dm-cache-policy-mq.c b/drivers/md/dm-cache-policy-mq.c
> index 7209fab..ac7d3b3 100644
> --- a/drivers/md/dm-cache-policy-mq.c
> +++ b/drivers/md/dm-cache-policy-mq.c
> @@ -287,9 +287,8 @@ static struct entry *alloc_entry(struct entry_pool *ep)
> static struct entry *alloc_particular_entry(struct entry_pool *ep, dm_cblock_t cblock)
> {
> struct entry *e = ep->entries + from_cblock(cblock);
> - list_del(&e->list);
>
> - INIT_LIST_HEAD(&e->list);
> + list_del_init(&e->list);
> INIT_HLIST_NODE(&e->hlist);
> ep->nr_allocated++;
>
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2013-11-15 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 9:47 [PATCH -next] dm cache policy mq:: use list_del_init instead of list_del/INIT_LIST_HEAD Wei Yongjun
2013-11-15 10:58 ` Joe Thornber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115105822.GA18770@debian \
--to=thornber@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=snitzer@redhat.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).