* [PATCH] drivers: md: Mark the function btree_insert_fn() as static in btree.c
@ 2013-12-14 12:59 Rashika Kheria
2013-12-14 20:44 ` Josh Triplett
0 siblings, 1 reply; 2+ messages in thread
From: Rashika Kheria @ 2013-12-14 12:59 UTC (permalink / raw)
To: linux-kernel; +Cc: Kent Overstreet, Neil Brown, linux-bcache, linux-raid, josh
This patch marks the function btree_insert_fn() as static in
bcache/btree.c because it is not used outside this file.
Thus, it also eliminates the following warning in bcache/btree.c:
drivers/md/bcache/btree.c:2220:5: warning: no previous prototype for ‘btree_insert_fn’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/md/bcache/btree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 5e2765a..dc6e2be 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -2217,7 +2217,7 @@ struct btree_insert_op {
struct bkey *replace_key;
};
-int btree_insert_fn(struct btree_op *b_op, struct btree *b)
+static int btree_insert_fn(struct btree_op *b_op, struct btree *b)
{
struct btree_insert_op *op = container_of(b_op,
struct btree_insert_op, op);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drivers: md: Mark the function btree_insert_fn() as static in btree.c
2013-12-14 12:59 [PATCH] drivers: md: Mark the function btree_insert_fn() as static in btree.c Rashika Kheria
@ 2013-12-14 20:44 ` Josh Triplett
0 siblings, 0 replies; 2+ messages in thread
From: Josh Triplett @ 2013-12-14 20:44 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Kent Overstreet, Neil Brown, linux-bcache,
linux-raid
On Sat, Dec 14, 2013 at 06:29:29PM +0530, Rashika Kheria wrote:
> This patch marks the function btree_insert_fn() as static in
> bcache/btree.c because it is not used outside this file.
>
> Thus, it also eliminates the following warning in bcache/btree.c:
> drivers/md/bcache/btree.c:2220:5: warning: no previous prototype for ‘btree_insert_fn’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/md/bcache/btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 5e2765a..dc6e2be 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -2217,7 +2217,7 @@ struct btree_insert_op {
> struct bkey *replace_key;
> };
>
> -int btree_insert_fn(struct btree_op *b_op, struct btree *b)
> +static int btree_insert_fn(struct btree_op *b_op, struct btree *b)
> {
> struct btree_insert_op *op = container_of(b_op,
> struct btree_insert_op, op);
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-14 20:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-14 12:59 [PATCH] drivers: md: Mark the function btree_insert_fn() as static in btree.c Rashika Kheria
2013-12-14 20:44 ` Josh Triplett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).