From: NeilBrown <neilb@suse.de>
To: Piergiorgio Sartor <piergiorgio.sartor@nexgo.de>
Cc: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>,
linux-raid@vger.kernel.org
Subject: Re: [PATCH] raid6check.c add page size check and repair
Date: Thu, 23 Jan 2014 12:30:58 +1100 [thread overview]
Message-ID: <20140123123058.72f07aa7@notabene.brown> (raw)
In-Reply-To: <20140120191022.GA8006@lazy.lzy>
[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]
On Mon, 20 Jan 2014 20:10:22 +0100 Piergiorgio Sartor
<piergiorgio.sartor@nexgo.de> wrote:
> Hi again,
>
> I'm polluting the mailing list now... Sorry!
>
> I found a couple of really stupid bugs, so this
> re-re-patch should fix them.
>
> Sorry for the noise.
>
Hi,
I've applied that patch - it looks believable.
However:
1/ If you could try putting a description of what the patch does, and why, at
the top, that would help a lot.
See http://www.ozlabs.org/~akpm/stuff/tpp.txt
2/ I'm not really happy about:
> @@ -217,26 +231,31 @@ int check_stripes(struct mdinfo *info, i
> block_index_for_slot[diskP] = data_disks;
> blocks[data_disks+1] = stripes[diskQ];
> block_index_for_slot[diskQ] = data_disks+1;
> -
> +/* Do we really need the code below? */
> +#if 0
> if (memcmp(p, stripes[diskP], chunk_size) != 0) {
> printf("P(%d) wrong at %llu\n", diskP, start);
> }
> if (memcmp(q, stripes[diskQ], chunk_size) != 0) {
> printf("Q(%d) wrong at %llu\n", diskQ, start);
> }
> +#endif
If you think it should be removed, then delete it completely. It will still
exist in the git history so they is no really loss of code.
If you aren't sure, then don't delete it at all. Ask. Explain your thinking
and seek opinions.
In either case it should be in a separate patch.
I've left the "#if 0" etc for now but if you could push through to a
resolution and send a patch I would appreciate it.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2014-01-23 1:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 18:18 [PATCH] raid6check.c add page size check and repair Piergiorgio Sartor
2014-01-20 16:11 ` Bernd Schubert
2014-01-20 18:22 ` Piergiorgio Sartor
2014-01-20 19:10 ` Piergiorgio Sartor
2014-01-23 1:30 ` NeilBrown [this message]
2014-01-23 18:40 ` Piergiorgio Sartor
2014-01-20 19:21 ` Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123123058.72f07aa7@notabene.brown \
--to=neilb@suse.de \
--cc=bernd.schubert@itwm.fraunhofer.de \
--cc=linux-raid@vger.kernel.org \
--cc=piergiorgio.sartor@nexgo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).