From: NeilBrown <neilb@suse.de>
To: Piergiorgio Sartor <piergiorgio.sartor@nexgo.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] raid6check.c: reduce verbosity
Date: Tue, 4 Feb 2014 16:10:25 +1100 [thread overview]
Message-ID: <20140204161025.579257b1@notabene.brown> (raw)
In-Reply-To: <20140201160334.GA9378@lazy.lzy>
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
On Sat, 1 Feb 2014 17:03:34 +0100 Piergiorgio Sartor
<piergiorgio.sartor@nexgo.de> wrote:
> This patch removes some printouts, which
> are not really useful here.
> These could be re-added later, in case a
> verbosity parameter will be provided.
>
> Signed off: piergiorgio.sartor@nexgo.de
>
> diff -uNrp a/raid6check.c b/raid6check.c
> --- a/raid6check.c 2014-01-23 19:36:23.151837870 +0100
> +++ b/raid6check.c 2014-02-01 16:56:14.123771170 +0100
> @@ -188,8 +188,6 @@ int check_stripes(struct mdinfo *info, i
> while (length > 0) {
> int disk[chunk_size >> CHECK_PAGE_BITS];
>
> - printf("pos --> %llu\n", start);
> -
> err = lock_stripe(info, start, chunk_size, data_disks, sig);
> if(err != 0) {
> if (err != 2)
> @@ -221,7 +219,6 @@ int check_stripes(struct mdinfo *info, i
> int disk = geo_map(i, start, raid_disks, level, layout);
> blocks[i] = stripes[disk];
> block_index_for_slot[disk] = i;
> - printf("%d->%d\n", i, disk);
> }
>
> qsyndrome(p, q, (uint8_t**)blocks, data_disks, chunk_size);
>
>
This and other 3 all applied - thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2014-02-04 5:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-01 16:03 [PATCH] raid6check.c: reduce verbosity Piergiorgio Sartor
2014-02-04 5:10 ` NeilBrown [this message]
2014-02-05 19:18 ` Piergiorgio Sartor
2014-02-05 22:30 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204161025.579257b1@notabene.brown \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=piergiorgio.sartor@nexgo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).