linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Ethan Wilson <ethan.wilson@shiftmail.org>
Cc: linux-raid <linux-raid@vger.kernel.org>
Subject: Re: Are we forced to use bad blocks list?
Date: Thu, 7 Aug 2014 12:27:42 +1000	[thread overview]
Message-ID: <20140807122742.571528be@notabene.brown> (raw)
In-Reply-To: <53DF7EA7.2070408@shiftmail.org>

[-- Attachment #1: Type: text/plain, Size: 2110 bytes --]

On Mon, 04 Aug 2014 14:37:59 +0200 Ethan Wilson <ethan.wilson@shiftmail.org>
wrote:

> On 04/08/2014 03:38, NeilBrown wrote:
> > On Thu, 31 Jul 2014 16:31:28 +0200 Ethan Wilson<ethan.wilson@shiftmail.org>
> > wrote:
> >
> >> Dear MD developers,
> >> it seems that with mdadm 3.3.1 , if an array has bad blocks disabled
> >> ....
> >> array is configured for BBL or not, and add a spare of the same type.
> >>
> > Why don't you want bad-block-lists?
> >
> > I'm not necessarily against having some why to avoid getting them
> > automatically ... possibly a 'policy' option in mdadm.conf.
> > But I'd like to make sure I understand all of your thinking first.
> >
> > Thanks,
> > NeilBrown
> 
> Hello Neil,
> 
> Well... on the ML, I think that we saw the badblocks code triggered only 
> once, and it was with the recent thread of Pedro Teixeira.
> 
> It seemed to me that his error condition could indicate that there might 
> be a bug in the bad blocks code. It's not clear to me how those zillions 
> of bad sectors could have been stored without some bug such as an 
> erroneous propagation of bad blocks, or erroneous handling or degraded 
> mode (he said he operated with a doubly degraded raid6 after 3 disks 
> dropped out).
> 
> Additionally, when he did fsck, that should have cleared the bad blocks 
> which were being written over, but he said that
> "When doing a fsck.ext4 of /dev/md0 it returns the following ( and I can 
> do it over and over again with the exact same errors) ..... "
> I think 'exact same errors' is not supposed to happen if I understand 
> the intent of BBL correctly.
> 
> So, I can't be sure, but I have the feeling it's possible that there are 
> still a few bugs in the BBL code. MD RAID in general is very stable and 
> I really like it so much, but maybe on production systems I'd keep the 
> BBL disabled still for a while, if possible.
> 

Fair enough.  Thanks for the explanation.

http://git.neil.brown.name/?p=mdadm.git;a=commitdiff;h=e2efe9e7bc73307f74a4c2e2197d6d4498dd46f0

will be in mdadm-3.3.2.

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2014-08-07  2:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31 14:31 Are we forced to use bad blocks list? Ethan Wilson
2014-08-04  1:38 ` NeilBrown
2014-08-04 12:37   ` Ethan Wilson
2014-08-07  2:27     ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140807122742.571528be@notabene.brown \
    --to=neilb@suse.de \
    --cc=ethan.wilson@shiftmail.org \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).