Re: [PATCH v1 0/0] raid5: fix init_stripe() inconsistencies

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]

On Wed, 13 Aug 2014 09:37:31 +0000 Markus Stockhausen
<stockhausen@collogia.de> wrote:

> commit 639a347254c4b8daa22ce09c281259dce7f6ba71
> Author: Markus Stockhausen <markus.stockhausen@collogia.de>
> Date:   Sun Aug 10 09:25:55 2014 +0000
> 
>     raid5: fix init_stripe() inconsistencies 
> 
>     1) remove_hash() is not necessary. We will only be called right after
>     get_free_stripe(). There we have already a call to remove_hash().
> 
>     2) Tracing prints out the sector of the freed stripe and not the sector
>     that we want to initialize.
> 
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 7f66741..c4cd245 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -527,9 +527,7 @@ static void init_stripe(struct stripe_head *sh, sector_t sector, int previous)
>  	BUG_ON(stripe_operations_active(sh));
>  
>  	pr_debug("init_stripe called, stripe %llu\n",
> -		(unsigned long long)sh->sector);
> -
> -	remove_hash(sh);
> +		(unsigned long long)sector);
>  retry:
>  	seq = read_seqcount_begin(&conf->gen_lock);
>  	sh->generation = conf->generation - previous;

Applied, thanks.

For future reference:
 - put "md" at the start of the subject line. e.g. "md/raid5:"
 - use "git show --format=email" or some other incantation which
   avoids  indenting the description.  Also avoid the "commit"
   line.  Author: and Date: are redundant but I don't think they
   are actually hurting.
 - Be sure to include a Signed-off-by: line.  Find and read the DCO
   (Developer's Certificate of Origin) to know what that means.
   This patch is sufficiently trivial that I won't insist, but it is a good
   habit to get into (git commit --amend --sign --no-edit)

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]