[PATCH v1 0/0] raid5: fix init_stripe() inconsistencies

[PATCH v1 0/0] raid5: fix init_stripe() inconsistencies

[Markus Stockhausen]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

commit 639a347254c4b8daa22ce09c281259dce7f6ba71
Author: Markus Stockhausen <markus.stockhausen@collogia.de>
Date:   Sun Aug 10 09:25:55 2014 +0000

    raid5: fix init_stripe() inconsistencies 

    1) remove_hash() is not necessary. We will only be called right after
    get_free_stripe(). There we have already a call to remove_hash().

    2) Tracing prints out the sector of the freed stripe and not the sector
    that we want to initialize.

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 7f66741..c4cd245 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -527,9 +527,7 @@ static void init_stripe(struct stripe_head *sh, sector_t sector, int previous)
 	BUG_ON(stripe_operations_active(sh));
 
 	pr_debug("init_stripe called, stripe %llu\n",
-		(unsigned long long)sh->sector);
-
-	remove_hash(sh);
+		(unsigned long long)sector);
 retry:
 	seq = read_seqcount_begin(&conf->gen_lock);
 	sh->generation = conf->generation - previous;

[-- Attachment #2: InterScan_Disclaimer.txt --]
[-- Type: text/plain, Size: 1650 bytes --]

****************************************************************************
Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail
irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und
vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte
Weitergabe dieser Mail ist nicht gestattet.

Über das Internet versandte E-Mails können unter fremden Namen erstellt oder
manipuliert werden. Deshalb ist diese als E-Mail verschickte Nachricht keine
rechtsverbindliche Willenserklärung.

Collogia
Unternehmensberatung AG
Ubierring 11
D-50678 Köln

Vorstand:
Kadir Akin
Dr. Michael Höhnerbach

Vorsitzender des Aufsichtsrates:
Hans Kristian Langva

Registergericht: Amtsgericht Köln
Registernummer: HRB 52 497

This e-mail may contain confidential and/or privileged information. If you
are not the intended recipient (or have received this e-mail in error)
please notify the sender immediately and destroy this e-mail. Any
unauthorized copying, disclosure or distribution of the material in this
e-mail is strictly forbidden.

e-mails sent over the internet may have been written under a wrong name or
been manipulated. That is why this message sent as an e-mail is not a
legally binding declaration of intention.

Collogia
Unternehmensberatung AG
Ubierring 11
D-50678 Köln

executive board:
Kadir Akin
Dr. Michael Höhnerbach

President of the supervisory board:
Hans Kristian Langva

Registry office: district court Cologne
Register number: HRB 52 497

****************************************************************************

Re: [PATCH v1 0/0] raid5: fix init_stripe() inconsistencies

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]

On Wed, 13 Aug 2014 09:37:31 +0000 Markus Stockhausen
<stockhausen@collogia.de> wrote:

> commit 639a347254c4b8daa22ce09c281259dce7f6ba71
> Author: Markus Stockhausen <markus.stockhausen@collogia.de>
> Date:   Sun Aug 10 09:25:55 2014 +0000
> 
>     raid5: fix init_stripe() inconsistencies 
> 
>     1) remove_hash() is not necessary. We will only be called right after
>     get_free_stripe(). There we have already a call to remove_hash().
> 
>     2) Tracing prints out the sector of the freed stripe and not the sector
>     that we want to initialize.
> 
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 7f66741..c4cd245 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -527,9 +527,7 @@ static void init_stripe(struct stripe_head *sh, sector_t sector, int previous)
>  	BUG_ON(stripe_operations_active(sh));
>  
>  	pr_debug("init_stripe called, stripe %llu\n",
> -		(unsigned long long)sh->sector);
> -
> -	remove_hash(sh);
> +		(unsigned long long)sector);
>  retry:
>  	seq = read_seqcount_begin(&conf->gen_lock);
>  	sh->generation = conf->generation - previous;

Applied, thanks.

For future reference:
 - put "md" at the start of the subject line. e.g. "md/raid5:"
 - use "git show --format=email" or some other incantation which
   avoids  indenting the description.  Also avoid the "commit"
   line.  Author: and Date: are redundant but I don't think they
   are actually hurting.
 - Be sure to include a Signed-off-by: line.  Find and read the DCO
   (Developer's Certificate of Origin) to know what that means.
   This patch is sufficiently trivial that I won't insist, but it is a good
   habit to get into (git commit --amend --sign --no-edit)

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

AW: [PATCH v1 0/0] raid5: fix init_stripe() inconsistencies

[Markus Stockhausen]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

> Von: NeilBrown [neilb@suse.de]
> Gesendet: Mittwoch, 20. August 2014 05:36
> An: Markus Stockhausen
> Cc: linux-raid@vger.kernel.org
> Betreff: Re: [PATCH v1 0/0] raid5: fix init_stripe() inconsistencies
> ...
> For future reference:
>  - put "md" at the start of the subject line. e.g. "md/raid5:"
>  - use "git show --format=email" or some other incantation which
>    avoids  indenting the description.  Also avoid the "commit"
>    line.  Author: and Date: are redundant but I don't think they
>    are actually hurting.
>  - Be sure to include a Signed-off-by: line.  Find and read the DCO
>    (Developer's Certificate of Origin) to know what that means.
>    This patch is sufficiently trivial that I won't insist, but it is a good
>    habit to get into (git commit --amend --sign --no-edit)

Hi Neil,

Good to know. Adapted my generator scripts for that. Do you want me to 
resend the RMW patches that way?

Markus
=

[-- Attachment #2: InterScan_Disclaimer.txt --]
[-- Type: text/plain, Size: 1650 bytes --]

****************************************************************************
Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte
Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail
irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und
vernichten Sie diese Mail. Das unerlaubte Kopieren sowie die unbefugte
Weitergabe dieser Mail ist nicht gestattet.

Über das Internet versandte E-Mails können unter fremden Namen erstellt oder
manipuliert werden. Deshalb ist diese als E-Mail verschickte Nachricht keine
rechtsverbindliche Willenserklärung.

Collogia
Unternehmensberatung AG
Ubierring 11
D-50678 Köln

Vorstand:
Kadir Akin
Dr. Michael Höhnerbach

Vorsitzender des Aufsichtsrates:
Hans Kristian Langva

Registergericht: Amtsgericht Köln
Registernummer: HRB 52 497

This e-mail may contain confidential and/or privileged information. If you
are not the intended recipient (or have received this e-mail in error)
please notify the sender immediately and destroy this e-mail. Any
unauthorized copying, disclosure or distribution of the material in this
e-mail is strictly forbidden.

e-mails sent over the internet may have been written under a wrong name or
been manipulated. That is why this message sent as an e-mail is not a
legally binding declaration of intention.

Collogia
Unternehmensberatung AG
Ubierring 11
D-50678 Köln

executive board:
Kadir Akin
Dr. Michael Höhnerbach

President of the supervisory board:
Hans Kristian Langva

Registry office: district court Cologne
Register number: HRB 52 497

****************************************************************************

Re: [PATCH v1 0/0] raid5: fix init_stripe() inconsistencies

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Wed, 20 Aug 2014 08:13:27 +0000 Markus Stockhausen
<stockhausen@collogia.de> wrote:

> > Von: NeilBrown [neilb@suse.de]
> > Gesendet: Mittwoch, 20. August 2014 05:36
> > An: Markus Stockhausen
> > Cc: linux-raid@vger.kernel.org
> > Betreff: Re: [PATCH v1 0/0] raid5: fix init_stripe() inconsistencies
> > ...
> > For future reference:
> >  - put "md" at the start of the subject line. e.g. "md/raid5:"
> >  - use "git show --format=email" or some other incantation which
> >    avoids  indenting the description.  Also avoid the "commit"
> >    line.  Author: and Date: are redundant but I don't think they
> >    are actually hurting.
> >  - Be sure to include a Signed-off-by: line.  Find and read the DCO
> >    (Developer's Certificate of Origin) to know what that means.
> >    This patch is sufficiently trivial that I won't insist, but it is a good
> >    habit to get into (git commit --amend --sign --no-edit)
> 
> Hi Neil,
> 
> Good to know. Adapted my generator scripts for that. Do you want me to 
> resend the RMW patches that way?

Probably -  I definitely want the s-o-b.  Wait 'til I've had a change to have
a look though.

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]