linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Andy Smith <andy@strugglers.net>
Cc: linux-raid@vger.kernel.org
Subject: Re: Shrinking number of devices on a RAID-10 (near 2) array
Date: Mon, 25 Aug 2014 21:26:14 +1000	[thread overview]
Message-ID: <20140825212614.5be558c9@notabene.brown> (raw)
In-Reply-To: <20140825103234.GH11855@bitfolk.com>

[-- Attachment #1: Type: text/plain, Size: 2150 bytes --]

On Mon, 25 Aug 2014 10:32:34 +0000 Andy Smith <andy@strugglers.net> wrote:

> On Sun, Aug 24, 2014 at 02:39:44PM +0000, Andy Smith wrote:
> > $ sudo ./mdadm /dev/md2 --grow --raid-devices=4
> > mdadm: Cannot set new_data_offset: RAID10 reshape not
> >        supported on this kernel
> 
> Grow.c from latest git:
> 
> 2397                         err = sysfs_set_num(sra, sd, "new_offset",
> 2398                                             new_data_offset);
> 
> For the first device in the for loop (sda3), the above line 2397 is
> returning -1.
> 
> 2399                 }
> 2400                 if (err < 0) {
> 2401                         if (errno == E2BIG && data_offset != INVALID_SECTORS) {
> 2402                                 pr_err("data-offset is too big for %s\n",
> 2403                                        dn);
> 2404                                 goto release;
> 2405                         }
> 2406                         if (sd == sra->devs &&
> 2407                             (errno == ENOENT || errno == E2BIG))
> 2408                                 /* Early kernel, no 'new_offset' file,
> 2409                                  * or kernel doesn't like us.
> 2410                                  * For RAID5/6 this is not fatal
> 2411                                  */
> 2412                                 return 1;
> 
> It reaches here line 2412 with errno == E2BIG.
> /sys/block/md2/md/dev-sda3/new_offset exists.
> 
> >From strace:
> 
> open("/sys/block/md2/md/dev-sda3/new_offset", O_WRONLY) = 4
> write(4, "128", 3)                      = -1 E2BIG (Argument list too long)
> close(4)                                = 0
> 
> Not sure where to debug next.

That comes from
	else if (new_offset > rdev->data_offset) {
		/* must not push array size beyond rdev_sectors */
		if (new_offset - rdev->data_offset
		    + mddev->dev_sectors > rdev->sectors)
				return -E2BIG;

in drivers/md/md.c in the kernel...

What does "mdadm --examine" on one of the devices report now that it is v1.0?

Particularly interested in the "Unused Space :" line.

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  reply	other threads:[~2014-08-25 11:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-23 16:31 Shrinking number of devices on a RAID-10 (near 2) array Andy Smith
2014-08-24  3:09 ` NeilBrown
2014-08-24  6:28   ` Craig Curtin
2014-08-24  6:45     ` NeilBrown
2014-08-24 13:19       ` Andy Smith
2014-08-24 14:39   ` Andy Smith
2014-08-25 10:32     ` Andy Smith
2014-08-25 11:26       ` NeilBrown [this message]
2014-08-25 11:34         ` Andy Smith
2014-08-28  9:53           ` Andy Smith
2014-08-29  3:53           ` NeilBrown
2014-08-29  4:02             ` Andy Smith
2014-08-29  4:18               ` NeilBrown
2014-08-29  4:26                 ` Andy Smith
2014-08-29  4:35                   ` NeilBrown
2014-08-29  4:42                     ` Andy Smith
2014-08-29  6:04                       ` NeilBrown
2014-08-29 20:45                         ` Andy Smith
2014-08-29 20:47   ` [PATCH 1/1] Grow: Report when grow needs metadata update Andy Smith
2014-09-03  3:28     ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140825212614.5be558c9@notabene.brown \
    --to=neilb@suse.de \
    --cc=andy@strugglers.net \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).