From: NeilBrown <neilb@suse.de>
To: Andy Smith <andy@strugglers.net>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/1] Grow: Report when grow needs metadata update
Date: Wed, 3 Sep 2014 13:28:10 +1000 [thread overview]
Message-ID: <20140903132810.4e593b3c@notabene.brown> (raw)
In-Reply-To: <1409345232-24837-1-git-send-email-andy@strugglers.net>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
On Fri, 29 Aug 2014 20:47:12 +0000 Andy Smith <andy@strugglers.net> wrote:
> Report when the array's metadata needs updating instead of just
> reporting the generic "kernel too old" message.
>
> Signed-off-by: Andy Smith <andy@strugglers.net>
> ---
> Grow.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Grow.c b/Grow.c
> index a9c8589..76bb35a 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -2255,7 +2255,9 @@ static int set_new_data_offset(struct mdinfo *sra, struct supertype *st,
> if (info2.space_before == 0 &&
> info2.space_after == 0) {
> /* Metadata doesn't support data_offset changes */
> - return 1;
> + pr_err("%s: Metadata version doesn't support"
> + " data_offset changes\n", devname);
> + goto release;
> }
> if (before > info2.space_before)
> before = info2.space_before;
Applied, thanks.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2014-09-03 3:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 16:31 Shrinking number of devices on a RAID-10 (near 2) array Andy Smith
2014-08-24 3:09 ` NeilBrown
2014-08-24 6:28 ` Craig Curtin
2014-08-24 6:45 ` NeilBrown
2014-08-24 13:19 ` Andy Smith
2014-08-24 14:39 ` Andy Smith
2014-08-25 10:32 ` Andy Smith
2014-08-25 11:26 ` NeilBrown
2014-08-25 11:34 ` Andy Smith
2014-08-28 9:53 ` Andy Smith
2014-08-29 3:53 ` NeilBrown
2014-08-29 4:02 ` Andy Smith
2014-08-29 4:18 ` NeilBrown
2014-08-29 4:26 ` Andy Smith
2014-08-29 4:35 ` NeilBrown
2014-08-29 4:42 ` Andy Smith
2014-08-29 6:04 ` NeilBrown
2014-08-29 20:45 ` Andy Smith
2014-08-29 20:47 ` [PATCH 1/1] Grow: Report when grow needs metadata update Andy Smith
2014-09-03 3:28 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903132810.4e593b3c@notabene.brown \
--to=neilb@suse.de \
--cc=andy@strugglers.net \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).