From: NeilBrown <neilb@suse.de>
To: shli@kernel.org
Cc: linux-raid@vger.kernel.org
Subject: Re: [patch v2 0/6] raid5: automatically batch adjacent full stripe write
Date: Thu, 11 Sep 2014 17:15:25 +1000 [thread overview]
Message-ID: <20140911171525.4ec2a88d@notabene.brown> (raw)
In-Reply-To: <20140910124009.810771309@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
On Wed, 10 Sep 2014 20:40:09 +0800 shli@kernel.org wrote:
> This is the 2nd attempt to make adjacent full stripe write together. The main
> change against v1 is how to detect if stripes can be batched. Also some bugs
> are fixed.
>
Thanks a lot for this - it looks quite good. I've read through most of it
and don't see anything worth mentioning.... except maybe to wonder why
to_addr_page() has an unused 'sh' argument. Maybe I'll just remove that(?).
I've pushed it you the 'devel' branch of my md git tree. I'll try to do some
testing of my own next week.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2014-09-11 7:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 12:40 [patch v2 0/6] raid5: automatically batch adjacent full stripe write shli
2014-09-10 12:40 ` [patch v2 1/6] raid5: use flex_array for scribble data shli
2014-09-10 12:40 ` [patch v2 2/6] raid5: add a new flag to track if a stripe can be batched shli
2014-09-10 12:40 ` [patch v2 3/6] raid5: track overwrite disk count shli
2014-09-10 12:40 ` [patch v2 4/6] RAID5: batch adjacent full stripe write shli
2014-09-10 12:40 ` [patch v2 5/6] raid5: handle io error of batch list shli
2014-09-10 12:40 ` [patch v2 6/6] raid5: handle expansion/resync case with stripe batching shli
2014-09-11 7:15 ` NeilBrown [this message]
2014-09-11 14:38 ` [patch v2 0/6] raid5: automatically batch adjacent full stripe write Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911171525.4ec2a88d@notabene.brown \
--to=neilb@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).