From: NeilBrown <neilb@suse.de>
To: Chris Murphy <lists@colorremedies.com>
Cc: Brassow Jonathan <jbrassow@redhat.com>,
"linux-raid@vger.kernel.org Raid" <linux-raid@vger.kernel.org>
Subject: Re: Status of discard support in MD RAID
Date: Mon, 15 Sep 2014 13:46:22 +1000 [thread overview]
Message-ID: <20140915134622.606855e9@notabene.brown> (raw)
In-Reply-To: <26CB8B36-9CD9-4EE0-BFF2-4B183DBDD033@colorremedies.com>
[-- Attachment #1: Type: text/plain, Size: 1763 bytes --]
On Thu, 11 Sep 2014 18:46:04 -0600 Chris Murphy <lists@colorremedies.com>
wrote:
>
> On Sep 11, 2014, at 5:38 PM, Brassow Jonathan <jbrassow@redhat.com> wrote:
>
> > Neil (or anyone else),
> >
> > I know that trim/discard support was added back in 2012 (commit 9db90880). However, I thought there were still issues regarding what happens when various sync operations occur. I'd like to turn on discard support in dm-raid.c (a oneline patch) if things are in order. I can enable any, all or none depending on your recommendation. (I assume RAID1/10 is easier than the parity RAIDs.)
>
> If all the controller and drive support it then it should pass through, but there's the problem whether the SSD supports deterministic trim. If it doesn't, a check check > md/sync_action will report mismatches in md/mismatch_cnt; and a repair will probably corrupt the volume. So you can still use trim with a drive that returns non-deterministic results with raid0/1/10, but you can't rely on the result of md/mismatch_cnt and you can't do repair type scrubs.
>
> For raid5/6, it's a problem to use trim if the drive returns non-deterministically for trimmed blocks. I'd think that in addition to DRAT being supported, it'd need to support DZAT.
md raid5/6 will not use trim unless the underlying device reports
"discard_zeros_data". That is a Linux internal field name. I don't know
exactly that it means in SCSI/SATA/whatever devices.
NeilBrown
>
> smartctl --identify=wb /dev/diskX | grep -i trim
>
>
> Chris Murphy
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2014-09-15 3:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 23:38 Status of discard support in MD RAID Brassow Jonathan
2014-09-12 0:46 ` Chris Murphy
2014-09-12 9:03 ` David Brown
2014-09-12 9:26 ` Brad Campbell
2014-09-15 3:50 ` NeilBrown
2014-09-12 9:39 ` Roman Mamedov
2014-09-13 20:19 ` Chris Murphy
2014-09-15 3:56 ` NeilBrown
2014-09-15 3:46 ` NeilBrown [this message]
2014-09-15 3:44 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915134622.606855e9@notabene.brown \
--to=neilb@suse.de \
--cc=jbrassow@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=lists@colorremedies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).