linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] lib/raid6: Add log level to printks
@ 2014-10-13 12:03 Anton Blanchard
  2014-10-14  1:51 ` NeilBrown
  0 siblings, 1 reply; 2+ messages in thread
From: Anton Blanchard @ 2014-10-13 12:03 UTC (permalink / raw)
  To: neilb; +Cc: linux-raid, linux-kernel


Signed-off-by: Anton Blanchard <anton@samba.org>
---

Index: b/lib/raid6/algos.c
===================================================================
--- a/lib/raid6/algos.c
+++ b/lib/raid6/algos.c
@@ -121,9 +121,9 @@ static inline const struct raid6_recov_c
 		raid6_2data_recov = best->data2;
 		raid6_datap_recov = best->datap;
 
-		printk("raid6: using %s recovery algorithm\n", best->name);
+		pr_info("raid6: using %s recovery algorithm\n", best->name);
 	} else
-		printk("raid6: Yikes! No recovery algorithm found!\n");
+		pr_err("raid6: Yikes! No recovery algorithm found!\n");
 
 	return best;
 }
@@ -157,18 +157,18 @@ static inline const struct raid6_calls *
 				bestperf = perf;
 				best = *algo;
 			}
-			printk("raid6: %-8s %5ld MB/s\n", (*algo)->name,
+			pr_info("raid6: %-8s %5ld MB/s\n", (*algo)->name,
 			       (perf*HZ) >> (20-16+RAID6_TIME_JIFFIES_LG2));
 		}
 	}
 
 	if (best) {
-		printk("raid6: using algorithm %s (%ld MB/s)\n",
+		pr_info("raid6: using algorithm %s (%ld MB/s)\n",
 		       best->name,
 		       (bestperf*HZ) >> (20-16+RAID6_TIME_JIFFIES_LG2));
 		raid6_call = *best;
 	} else
-		printk("raid6: Yikes!  No algorithm found!\n");
+		pr_err("raid6: Yikes!  No algorithm found!\n");
 
 	return best;
 }
@@ -194,7 +194,7 @@ int __init raid6_select_algo(void)
 	syndromes = (void *) __get_free_pages(GFP_KERNEL, 1);
 
 	if (!syndromes) {
-		printk("raid6: Yikes!  No memory available.\n");
+		pr_err("raid6: Yikes!  No memory available.\n");
 		return -ENOMEM;
 	}
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] lib/raid6: Add log level to printks
  2014-10-13 12:03 [PATCH] lib/raid6: Add log level to printks Anton Blanchard
@ 2014-10-14  1:51 ` NeilBrown
  0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2014-10-14  1:51 UTC (permalink / raw)
  To: Anton Blanchard; +Cc: linux-raid, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

On Mon, 13 Oct 2014 23:03:16 +1100 Anton Blanchard <anton@samba.org> wrote:

> 
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
> 
> Index: b/lib/raid6/algos.c
> ===================================================================
> --- a/lib/raid6/algos.c
> +++ b/lib/raid6/algos.c
> @@ -121,9 +121,9 @@ static inline const struct raid6_recov_c
>  		raid6_2data_recov = best->data2;
>  		raid6_datap_recov = best->datap;
>  
> -		printk("raid6: using %s recovery algorithm\n", best->name);
> +		pr_info("raid6: using %s recovery algorithm\n", best->name);
>  	} else
> -		printk("raid6: Yikes! No recovery algorithm found!\n");
> +		pr_err("raid6: Yikes! No recovery algorithm found!\n");
>  
>  	return best;
>  }
> @@ -157,18 +157,18 @@ static inline const struct raid6_calls *
>  				bestperf = perf;
>  				best = *algo;
>  			}
> -			printk("raid6: %-8s %5ld MB/s\n", (*algo)->name,
> +			pr_info("raid6: %-8s %5ld MB/s\n", (*algo)->name,
>  			       (perf*HZ) >> (20-16+RAID6_TIME_JIFFIES_LG2));
>  		}
>  	}
>  
>  	if (best) {
> -		printk("raid6: using algorithm %s (%ld MB/s)\n",
> +		pr_info("raid6: using algorithm %s (%ld MB/s)\n",
>  		       best->name,
>  		       (bestperf*HZ) >> (20-16+RAID6_TIME_JIFFIES_LG2));
>  		raid6_call = *best;
>  	} else
> -		printk("raid6: Yikes!  No algorithm found!\n");
> +		pr_err("raid6: Yikes!  No algorithm found!\n");
>  
>  	return best;
>  }
> @@ -194,7 +194,7 @@ int __init raid6_select_algo(void)
>  	syndromes = (void *) __get_free_pages(GFP_KERNEL, 1);
>  
>  	if (!syndromes) {
> -		printk("raid6: Yikes!  No memory available.\n");
> +		pr_err("raid6: Yikes!  No memory available.\n");
>  		return -ENOMEM;
>  	}
>  


Applied - thanks.

NeilBrown

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-14  1:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-13 12:03 [PATCH] lib/raid6: Add log level to printks Anton Blanchard
2014-10-14  1:51 ` NeilBrown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).